1914687 - "scrollbutton-up" of long bookmarks menupopup no longer working

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Alice0775 White]

Steps to reproduce:

1. Bookmark a lot of Bookmarks so that Bookmarks menupopup can be scrolled.
2. Expand the Bookmarks menu
3. Scroll the menupopup to bottom in any way.
4. Attempt to scroll the menupopup to top by using ^ scrollbutton-up button

Actual results:
The "scrollbutton-up" does not work.
No mouse hoover effect.
Not scroll when mouse over it

Expected results:
Change style when mouse hover it
Should start scrolling when mouse over it

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=773aed942ff98525ee9bc2c03fd96dbd6c0eee96&tochange=9d4782d16aacb9b51e440042a677f6c5c68a0ca9

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1913322, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Alice0775 White]

Reproduced on Windows11, ubuntu22.04 and Linux Mint21 cinnamon.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1914687 - Make sure arrowscrollbox buttons draw on top of scroller. r=dao

In bug 1913322 I tweaked the approach we use to maintain layout
stability when showing and hiding these so that the scrollbox overlaps
them (before we used to have an extra clip).

The DOM order is scrollbutton-up, scrollbox, scrollbutton-down, but we
need to make sure that the scrollbutton-up paint on top of the
scrollbox, otherwise it won't be hittable.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aacc1a11d786
Make sure arrowscrollbox buttons draw on top of scroller. r=dao,desktop-theme-reviewers

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/aacc1a11d786

Comment 6

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Firefox Nightly build from 2024-08-23, on Windows 11, while following the steps from Comment 0.
Verified as fixed on Firefox 131.0b4, using Windows 11, Ubuntu 22.04 and macOS 14.6. The "scrollbutton-up" button is now working.