Closed Bug 191489 Opened 22 years ago Closed 22 years ago

merge gkview.dll into gklayout

Categories

(Core :: Layout, defect, P2)

Product:
Core
Component:
Layout
Platform:
x86
Windows 2000
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.4alpha

People

(Reporter: alecf, Assigned: alecf)

References

Details

(Keywords: memory-footprint, Whiteboard: fixed on minimo branch)

I've mentioned this a few times, but there's no really good reason to keep gkview.dll as a seperate dll. A few people have suggested that this belongs in gklayout.dll, so that's where we'll put it. roc sez that this will also be helpful for the deCOMtamination effort.
Blocks: 191033
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla1.4beta
I just checked this into the MiniMo branch.. is there some deCOMification that we can do now?
Whiteboard: fixed on minimo branch
Target Milestone: mozilla1.4beta → mozilla1.4alpha
Yeah ... what is the MiniMo branch? When is this going to land on the trunk?
See http://tinderbox.mozilla.org/showbuilds.cgi?tree=MiniMo We'll be trying to land this (the whole branch) on the trunk early in 1.4alpha
So what all changes have gone in on minimo? Is there a way I can search for the relevant bugs?
Here's a link to all the changes that have gone in (this is a big query, so only click on this link when you have time to slow down bonsai for a minute or two) http://bonsai.mozilla.org/cvsqueryform.cgi?module=MozillaTinderboxAll&branch=MINIMO_01302003_BRANCH&cvsroot=/cvsroot&date=day&who=alecf%25netscape.com We branched on 1-30-2003, and its only been a small group of developers
That actually shows only the last day.... but ok, I got the query adjusted properly. Looks like this is mostly makefile and linking changes, with no actual code changes. Is that correct? (If so, then I'll stop worrying about it ;) )
Wait. That was only showing alecf's changes..... What sorts of review did the following changes get? A) Replacement of nsFileSpec with nsIFile B) The --disable-xul change (I only looked at the nsCSSDeclaration changes, and they look fishy to me -- all that stuff should most certainly be inside the ENABLE_XUL #ifdef....) Is there a bug for MiniMo where this discussion would be more appropriate?
Alec, my kickstart-nsIView-deCOMification patch is in bug 109772. Once you land the mini-mo branch on the trunk, I'll iterate the patch to take advantage of direct linkage. I want to do all the deCOMtamination work on the trunk. BTW have you considered combining gkgfx and gkwidget? AFAIK it's impossible to use one without the other (people have talked about a command-line HTML printing tool that would use GFX only, but we don't need to worry about the footprint of that).
As long as such a tool would not require a working X server to run (ie does not depend on GTK at runtime).... ;)
oops, my bad - grabbed the wrong bookmark :) Well you can figure out the right bonsai query anyway. I've just filed bug 194240 for the MiniMo landing. Not to worry, this stuff is going to go through a review cycle or two or three. Lets take discussion over to that bug.
Actually, we may as well merge gkgfx and gkwidget into gklayout.
funny, bryner, darin, pavlov and I were just talking about that yesterday.. I'll file a new bug about that too...I just filed bug 194395 about it.
How about docshell? Have you already moved that in?
And then there's imglib. Also, GFX-GTK has a number of .sos that can be combined. All this merging is certainly a footprint and startup win, and also allows for easier deCOMtamination. My only worry is that it makes development harder because a single change to any one of these modules forces relinking of a really, really large object. It already takes some number of minutes on my non-wimpy home machine. Hmm...
Dunno about linking imglib in there too; you may want to check with pav.
Well, no-one uses imglib without layout, and layout depends on imglib.
The "merge gfx and widget component DLLs into the layout dll" bug is bug 194385.
oops, already landed this.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.