1914934 - [WebGPU] 6GB memory spike followed by OOM crash on https://threejs.org/examples/?q=webgpu#webgpu_cubemap_adjustments

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P1)

Description

[Mayank Bansal]

Go to https://threejs.org/examples/?q=webgpu#webgpu_cubemap_adjustments

AR: immediate 6GB spike in memory use, folowed by tab crash. Sometimes the whole system may become unstable.

Crash: https://crash-stats.mozilla.org/report/index/396ef55b-fcee-4f82-b9ba-84b840240826#tab-bugzilla

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Chrome runs the demo just fine.
I can repro the OOM+Crash on a build from Feb2024. So this is not a recent regression.

Comment 3

[Teodor Tanasoaia [:teoxoy]]

This has the same underlying cause as Bug 1911540.

Comment 4

[Mayank Bansal]

FWIW, memory use on Chrome doesnt exceed ~500MB and the demo loads and runs smoothly.

Comment 5

[Teodor Tanasoaia [:teoxoy]]

Do we want to keep this open to track the issue of us using too much memory or should we open a new bug?

Comment 6

[Teodor Tanasoaia [:teoxoy]]

Mayank could you try to repro it on a recent nightly? I have a hunch that this might be resolved. I think Bug 1887287 was a related issue and it was resolved.

Comment 7

[Mayank Bansal]

It still repros.

Comment 8

[Teodor Tanasoaia [:teoxoy]]

The underlying cause here was us not implementing Bug 1922097. The console was full of:

Uncaught TypeError: GPUQueue.copyExternalImageToTexture: 'source' member of GPUCopyExternalImageSourceInfo could not be converted to any of: ImageBitmap, HTMLCanvasElement, OffscreenCanvas.

The three.js library was trying to load an asset by creating a texture and then copying via copyExternalImageToTexture. The app was trying to do so every frame because from its perspective the asset didn't load yet. So every frame, there was a texture being created after which JS execution stopped at copyExternalImageToTexture due to the TypeError, causing memory usage to balloon.

Comment 9

[Erich Gubler [:ErichDonGubler]]

This specific page no longer encounters an issue on my M1 MacBook Pro and my Windows 11 workstation.

Comment 10

[Teodor Tanasoaia [:teoxoy]]

I opened https://github.com/gfx-rs/wgpu/issues/7460 to track the wgpu-core implementation of OOM detection & mitigation.