Closed Bug 1915028 Opened 6 months ago Closed 5 months ago

[wpt-sync] Sync PR 47796 - [Masonry] Introduce parsing for masonry-slack

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47796 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47796
Details from upstream follow.

Sam Davis Omekara (from Dev Box) <samomekarajr@microsoft.com> wrote:

[Masonry] Introduce parsing for masonry-slack

This CL introduces the parsing for css masonry property:
masonry-slack
https://tabatkins.github.io/specs/css-masonry/#propdef-masonry-slack

This is part of: https://chromestatus.com/feature/5149560434589696

The properties are behind the CSSMasonryLayout feature flag.

Bug: 343257585
Change-Id: If6759bf828c8e8d52e0e307e3e9642f9fbfc1c1d
Reviewed-on: https://chromium-review.googlesource.com/5801223
WPT-Export-Revision: 63a19f8711c8f7a54c4f5b5c866053c9d1f7f3d2

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 6 subtests

Status Summary

Firefox

OK : 3
PASS: 5
FAIL: 12

Chrome

OK : 3
PASS: 5
FAIL: 12

Safari

OK : 3
PASS: 5
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-masonry/tentative/parsing/masonry-slack-computed.html [wpt.fyi]
    • Property masonry-slack value 'normal': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-slack value '10px': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-slack value '20%': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-slack value 'calc(20% + 10px)': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-slack value 'calc(-0.5em + 10px)': FAIL (Chrome: FAIL, Safari: FAIL)
    • Property masonry-slack value 'calc(0.5em + 10px)': FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-masonry/tentative/parsing/masonry-slack-valid.html [wpt.fyi]
    • e.style['masonry-slack'] = "normal" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-slack'] = "0" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-slack'] = "1px" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-slack'] = "calc(2em + 3ex)" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-slack'] = "4%" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
    • e.style['masonry-slack'] = "5vmin" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9d08fca7e54 [wpt PR 47796] - [Masonry] Introduce parsing for masonry-slack, a=testonly https://hg.mozilla.org/integration/autoland/rev/dee6e2c415c7 [wpt PR 47796] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.