1915114 - `./mach build binaries && ./mach run` doesn't pick up binary changes

Status: NEW

(Firefox Build System :: General, defect, P3)

Description

[Andreas Pehrson [:pehrsons]]

Attachment: .mozconfig

I'm seeing this on macOS, arm64. I haven't tested other platforms. I had some trouble with sccache and dependency files but that seems all right now with export SCCACHE_DIRECT=false in .zshrc. mk_add_options was not sufficient.

I am testing this by adding the line config.colorSpaceName = kCGColorSpaceSRGB; right after this line.

Then with one display with color preset "Apple XDR Display (P3-1600 nits)" showing a test image, I ./mach run with media.getdisplaymedia.screencapturekit.enabled set to true (needs restart), go to gum_test.html and capture the screen with the test image.

I use macOS' color picker app to check the color of the 75% green portion of the test image, in the video element on gum_test.html. It should be rgb(3, 191, 2), but when not effective it is rgb(86, 187, 56) for my P3 display. After a few rounds of this the naked eye is sufficient to detect the difference too.

I see that after ./mach build binaries, the sRGB config does not take effect as expected, although objdir/dist/bin/XUL was written to. Following up with ./mach build makes it take effect and all is well.

Comment 1

[Andreas Pehrson [:pehrsons]]

I see that ./mach build is what updates objdir/dist/Nightly.app/Contents/MacOS/XUL, which is out of sync with objdir/dist/bin/XUL after just ./mach build binaries.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:ahochheiden, could you have a look please?

For more information, please visit BugBot documentation.