1915176 - Clean up code arround updating HTTPS-Only/-First exceptions on redirects

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P3)

Description

[Malte Jürgens [:maltejur]]

Follow-up to Bug 1904238. With the changes from that patch, we can now clean up this section. Due to Bug 1904238 clearing the HTTPS-Only flag on every redirect, we should no longer need to clear it in the code linked above. This also means we can get rid of HTTPS_FIRST_EXEMPT_NEXT_LOAD, which currently is a bit confusing. It just exists to "survive" our current clearing of the exemption flag, as there are some cases where we know that the load should be exempt from HTTPS-First (for example loading http history entries) before we reach the code clearing the exemption status.

Comment 1

[Malte Jürgens [:maltejur]]

Attachment: Bug 1915176 - Clean up code arround updating HTTPS-Only/-First exceptions on redirects r?manuel!,freddyb!

With the changes from Bug 1904238, the HTTPS-Only flag now gets cleared on every
redirect. That means we do not need to clear it in
TestSitePermissionAndPotentiallyAddExemption anymore, and also that
HTTPS_FIRST_EXEMPT_NEXT_LOAD is not required anymore, because we now clear the
flag before HTTPS_FIRST_EXEMPT_NEXT_LOAD would be set.

Comment 2

[Malte Jürgens [:maltejur]]

Attachment: Bug 1915176 - Write test for clearing HTTPS-First exemption on redirect r?manuel!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15888d539895
Clean up code arround updating HTTPS-Only/-First exceptions on redirects r=manuel,freddyb
https://hg.mozilla.org/integration/autoland/rev/722f5683c3af
Write test for clearing HTTPS-First exemption on redirect r=manuel

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/15888d539895
https://hg.mozilla.org/mozilla-central/rev/722f5683c3af