Closed Bug 1915223 Opened 8 months ago Closed 8 months ago

[wpt-sync] Sync PR 47819 - [layout] Process top-layer elements last in OutOfFlowLayoutPart.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47819 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47819
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[layout] Process top-layer elements last in OutOfFlowLayoutPart.

We had a couple of issues with top-layer elements. The primary cause
of these issues is that we treated top-layer elements like other
OOF-positioned elements. This had a few side-effects - primarily
that they were "interleaved" with other OOF-positioned elements.

As top-layer elements bypass the standard add/remove logic they can
be inserted/removed directly to the top-layer, which would result
in an invalid candidate in the OOF-positioned logic.

The fix is to process the top-layer elements at the end of the
OutOfFlowLayoutPart one-by-one, once all the side effects are complete.

Bug: 352005194, 358664966
Change-Id: Ib2c1219e831af364971a3c370e35190684a249e1
Reviewed-on: https://chromium-review.googlesource.com/5797905
WPT-Export-Revision: e9c45a13963a2478fbceb5c78c9011b3bc7ed9d2

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

OK : 1
PASS: 2
FAIL: 2

Safari

OK : 1
PASS: 2
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30fe464d9a15 [wpt PR 47819] - [layout] Process top-layer elements last in OutOfFlowLayoutPart., a=testonly https://hg.mozilla.org/integration/autoland/rev/e3ae1859b500 [wpt PR 47819] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/30fe464d9a15
https://hg.mozilla.org/mozilla-central/rev/e3ae1859b500

Status: NEW → RESOLVED
Closed: 8 months ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.