191524 - Options Dialog UI

Status: RESOLVED DUPLICATE of bug 274712

(Firefox :: Settings UI, defect, P1)

Description

[Ben Goodger (use ben at mozilla dot org for email)]

Per http://www.mozillazine.org/forums/viewtopic.php?t=5077

see also: http://www.bengoodger.com/software/mb/

Comment 1

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: the diff

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch for mozilla/browser

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch for mozilla/toolkit

minor theme update + support clearing satchel

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch for mozilla/modules/libpr0n/decoders/icon

null check in icon uri decoder fixes crash when clearing downloads when
downloads sidebar is open.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 113270 [details] [diff] [review]
patch for mozilla/toolkit

hey joe, I implemented the |RemoveAllEntries| method on nsFormHistory so I
could add a clear satchel button to prefs.

Comment 6

[Asa Dotzler [:asa]]

I'm getting a clean tree now and I'll start banging on this asap.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: oops, forgot to add prefs.css

Comment 8

[Joe Hewitt (gone)]

Comment on attachment 113270 [details] [diff] [review]
patch for mozilla/toolkit

r=me

Comment 9

[Stuart Parmenter]

Comment on attachment 113271 [details] [diff] [review]
patch for mozilla/modules/libpr0n/decoders/icon

r=/moa=pavlov

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 113271 [details] [diff] [review]
patch for mozilla/modules/libpr0n/decoders/icon

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: add licenses, ensure XULPP works properly.

Comment 12

[Asa Dotzler [:asa]]

Ben, in today's build the toolbars are all screwed up and customization is
hosed. I'm getting some output to the console when customizing. Could this be
related to your checkin? 

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "document.getAnonymousNodes(theToolbar) has
no properties"]' when calling method: [nsIDOMEventListener::handleEvent]" 
nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location:
"<unknown>"  data: yes]
************************************************************

Comment 13

[alanjstr]

Is there a bug for tracking the Toolbar Customization bugs created from this? 
My URLbar and bookmarks toolbar never go back to being active.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Looking...

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

The customize toolbar bustage appears independent of these changes - I did not
touch any of the customize toolbar code, and I backed out my changes in my own
tree and without the new preferences updates the toolbar is still busted in
today's build. I figure some change from the mozilla trunk from yesterday's
build is responsible. 

Comment 16

[David P James]

See bug 191637 for toolbar bustage.

This bug should really be all OSes too...

Comment 17

[Sébastien Delahaye]

*** Bug 198911 has been marked as a duplicate of this bug. ***

Comment 18

[Simon Paquet [:sipaq]]

Why is this bug still open, the pref reorg detailed in
http://www.bengoodger.com/software/mb/preferences.txt is done AFAICS?

Comment 19

[Simon Paquet [:sipaq]]

OK, forget all the stupid stuff I've said. I'm too dumb to take a look at the
blocking bugs. Sorry for bugspam.

Comment 20

[Pham]

Is http://bugzilla.mozilla.org/show_bug.cgi?id=204394 part of this?

Comment 21

[Mike Connor [:mconnor]]

taking QA contact, sorry about the bugspam

Comment 22

[Ben Goodger (use ben at mozilla dot org for email)]

Tracking remaining Options dialog work. 

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

blocking1.0+ for the proposal in URL field. 

http://www.bengoodger.com/software/mb/options/options.txt

Comment 24

[u60234]

No "Advanced" or "Exceptions" button for "Enable JavaScript"? Scrolling text, or
address hiding in the Status Bar, and disabled context menus are things that
many users would like to block, even if they want to enable JavaScript for other
things. 

Comment 25

[Noam Avnery]

(In reply to comment #23)
> blocking1.0+ for the proposal in URL field. 
> 
> http://www.bengoodger.com/software/mb/options/options.txt
> 

From options.txt:
"Cookies are pieces of information stored by web pages on your computer. "

IMHO "web sites" might be better than "web pages".

Comment 26

[Mike Connor [:mconnor]]

*** Bug 244546 has been marked as a duplicate of this bug. ***

Comment 27

[Mike Connor [:mconnor]]

*** Bug 245533 has been marked as a duplicate of this bug. ***

Comment 28

[Mike Connor [:mconnor]]

*** Bug 247100 has been marked as a duplicate of this bug. ***

Comment 29

[Mike Connor [:mconnor]]

*** Bug 247102 has been marked as a duplicate of this bug. ***

Comment 30

[Blake Ross]

*** Bug 231054 has been marked as a duplicate of this bug. ***

Comment 31

[Greg Campbell]

All the "Exceptions" buttons under Web Features need ellipses since they open a
dialog. Exceptions --> Exceptions...

The word "exceptions" doesn't make sense for the software installation pref.
Change the button to something like "Allowed sites..."

Comment 32

[Jo Hermans]

*** Bug 252822 has been marked as a duplicate of this bug. ***

Comment 33

[Asa Dotzler [:asa]]

191524 was blocking, so I've set this to blocking in case there's anything left
to do. Feel free to remove the blocking flag if it isn't necessary

Comment 34

[Mike Connor [:mconnor]]

dropping the flag, there's stuff to do post-1.0 wrt the further rework proposed
in the URL

Comment 35

[David P James]

Attachment: Unreadable Preferences UI

Are you sure about that Mike? Until the type of mess visible in this screenshot
is fixed (as it is in Pinball, I might add) this should probably still be
blocking. I alerted someone (Ben in the forums I think) shortly after this
appeared so it has been known about for 20 months or more.

Comment 36

[Mike Connor [:mconnor]]

that's a specific bug, already on file, and blocking 1.0.  The meta bug as a
whole shouldn't block stuff, only certain specific issues should.

Comment 37

[alanjstr]

Well, that bug doesn't happen to be blocking this one, so since this is the
meta-bug, can you add it?  FYI, the hardcoded colors have been there since
before 0.5.  

Comment 38

[David P James]

What bug would that be? bug 222799 seems to fit the bill... except it's not 
blocking 1.0 (in fact it was minused - twice). Neither is bug 259676. Bug 
261306 is unconfirmed and is probably a dupe of one of the above. 

Comment 39

[Patrick]

This bug has morphed so much and according to comment 36 this is now a meta-bug.

Meanwhile bug 247100 and bug 247102 have been marked as a dupe of this one. Both
those bugs aren't meta bugs, and the specific issues these bugs deal with aren't
resolved yet. Imho a polished 1.0 shouldn't ship without these things fixed.

Point being: is this a meta/tracking bug or not? If so, some of the dupes and
dependencies must be re-evaluated and separate issues must be listed in separate
bugs.

Or am i mistaken?

Comment 40

[Mike Connor [:mconnor]]

Everyone has the bug that they think is crucial for 1.0.  Those bugs will be
fixed by the pref reorg, but are both pretty trivial and not a priority at all.

Comment 41

[Patrick]

(In reply to comment #40)
> Everyone has the bug that they think is crucial for 1.0.  Those bugs will be
> fixed by the pref reorg, but are both pretty trivial and not a priority at all.

I know everyone has a favorite bug and bugzilla definitely isn't the place for
people to ask for their fave bugs to be fixed. So that's not what i'm after. I'm
sorry if my "imho" got across wrong there.
:)

I'm only wondering [comment 39] if this bug now is a meta bug [as stated by
comment 36] or not. If this is the case, then non-meta bugs duped to this one
should possibly be considered again.

Comment 42

[Mike Connor [:mconnor]]

its sort of a meta bug, but if bugs are fixed by the main plan (see URL) then
its better to dupe than to leave open.

Comment 43

[(not currently active) Ted Mielczarek]

*** This bug has been marked as a duplicate of 274712 ***

Comment 44

[Mike Connor [:mconnor]]

sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs,
filter on "beltznerLovesGoats" to get rid of this mass change