1915402 - URIFixup should replace 0.0.0.0 with 127.0.0.1

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement)

Description

[Valentin Gosu [:valentin]]

In bug 1889130 we made Firefox not load 0.0.0.0 addresses, as that could be a security risk.
However, in many developer workflows, one would start a python server listening on all addresses, and the server would print "Listening on http://0.0.0.0:8080"
Clicking on that link used to work, but now it doesn't.
I think we can make things a bit nicer for developers by fixing up the URL from http://0.0.0.0 to http://127.0.0.1 and http://[::] to http://[::1] in URIFixup

Comment 1

[Hsin-Yi Tsai (she/her)[:hsinyi]]

This looks a follow-up from bug 1889130 that we should fix sooner than later. Would you agree?

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1915402 - use 127.0.0.1 for 0.0.0.0 access from the address bar to make life easier for web devs, r?valentin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d8a1f790562
use 127.0.0.1 for 0.0.0.0 access from the address bar to make life easier for web devs, r=valentin,mak

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing mochitests failures in browser_UrlbarInput_formatValue.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_UrlbarInput_formatValue.js | Correct part of the URL is de-emphasized - "[::1]" == "[::]" -

Comment 5

[:Gijs (he/him)]

Oops. I've updated the patch and pushed to try.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/683bebc3099e
use 127.0.0.1 for 0.0.0.0 access from the address bar to make life easier for web devs, r=valentin,mak,urlbar-reviewers

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/683bebc3099e