1915717 - [network-markers] Expose http protocol version for a request in the profiler network tab

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Andrew Creskey [:acreskey]]

There are vast differences between version of the HTTP protocol, 1.1/2/3, and it would be useful to have this exposed in the profiler.

Comment 1

[Sean Kim [:sekim]]

Attachment: Bug 1915717 - [network markers] Expose http protocol version for a request in the profiler network tab r=acreskey,#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72d0981a52ea
[network markers] Expose http protocol version for a request in the profiler network tab r=acreskey,necko-reviewers,profiler-reviewers,devtools-reviewers,kershaw,aabh,jdescottes

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/72d0981a52ea

Comment 4

[Sean Kim [:sekim]]

PR on GitHub

Comment 5

[Andrew Creskey [:acreskey]]

This might not be working as expected -- I'm always seeing HTTP/1.1 for the version.
But when I load a site like Cloudflare I can verify via dev tools or logs that I'm connecting over HTTP/2 or HTTP/3
Sean, can you take a look?

Comment 6

[Sean Kim [:sekim]]

I think this has to do with the fact that we return "http/1.1" when HttpVersion is invalid or unavailable. We might need to return something else or create a separate method like our initial approach.

Comment 7

[Sean Kim [:sekim]]

Kershaw, any thoughts on this?

Comment 8

[Kershaw Chang [:kershaw]]

(In reply to Sean Kim from comment #7)

Kershaw, any thoughts on this?

Looking at your patch again.
It looks like at every place of profiler_add_network_marker, you are using mRequestHead.Version().
I think we should use the version from mResponseHead instead.
Note that mResponseHead will be only available after OnStartRequest, so we need to take care of this.

Comment 9

[Sean Kim [:sekim]]

Will file another bug for easier version tracking