Closed Bug 1915918 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 47897 - Fixes test cases to allow unit cancellation in calc() to produce number values

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
131 Branch
Tracking Flags:
Tracking Status
firefox131 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47897 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47897
Details from upstream follow.

Sam Weinig <sam@webkit.org> wrote:

Fixes test cases to allow unit cancellation in calc() to produce number values

Updates test cases that assume that calc(1px / 1px) does not produce a number value.

See discussions in https://github.com/w3c/csswg-drafts/issues/10733 and https://github.com/w3c/csswg-drafts/issues/10752.

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 240 subtests

Status Summary

Firefox

OK : 1
PASS : 229[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 239[GitHub]
FAIL : 1
ERROR: 1

Chrome

OK : 2
PASS : 243
FAIL : 19

Safari

OK : 2
PASS : 260
FAIL : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

  • /css/css-typed-om/stylevalue-subclasses/cssScale.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

  • /css/css-typed-om/stylevalue-subclasses/cssScale.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/447b9b189ce7 [wpt PR 47897] - Fixes test cases to allow unit cancellation in calc() to produce number values, a=testonly https://hg.mozilla.org/integration/autoland/rev/38238226ead5 [wpt PR 47897] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/447b9b189ce7
https://hg.mozilla.org/mozilla-central/rev/38238226ead5

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox131: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.