1916124 - Add an update-manual doorhanger that indicates that the user is not out of date but update is broken

Status: NEW

(Toolkit :: Application Update, enhancement, P3)

Description

[[e-mail]]

Attachment: Tout de Firefox problème de mise à jour.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

just stay open Firefox Nighty (131.01a and before version thru November 2023), it will show need update available, but it all ready update. From November 2023 thru now!

Same problem with Firefox (129.0.2 and before version thru November 2023). But now not show update available, but not show in profile all update of Firefox history.

Actual results:

For Nighty: After crash Windows 10 (from bad update NVidia driver November 2023 and some manipulation in windows account profile categories and name profile in Windows account: The problem started with Firefox (both of them):
But i copied folder of my personal information (Profiles of Firefox) to created new profile and after paste folders to having all stuff before. Now they show update is available, But is allready update each time they really have new update and in my profile in historical update they still show all last update before November 2023, not after to now!!!

Near Same for Firefox: After crash Windows 10 ..... same than upper comments (both of them):
But i copied folder of my personal information (Profiles of Firefox) to created new profile and after paste folders to having all stuff before. From November thru july approx. they show update is available, But i do some manipulation account and from july thru now Firefox is know if is need update, is work better. is all ready update each time they really have new update. But 1 problem stay: in my profile in historical update they still show all last update before November 2023, not after to now!!!

Expected results:

For Firefox Nighty: They having some wrong information about account, or still having mix account from Windows information and Firefox, and not stay update good information.

Same for Firefox, but i thing i repared some files (copied pasted files account), but cannot updated all wrong information integrity!

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Application Update' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Max Christian Pohle [:/dev/max]]

Hi Neo! Let me try to summarize you bug report. Please let me know if I got something wrong.

• You have Firefox and Nightly installed.
• While you have both open simultaneously you keep seeing update notifications.
• You reinstalled Windows after that driver problem.
• You freshly installed Nightly.
• You freshly installed Firefox.
• You tried to restore your profile from a backup.

How exactly have you restored the files? You wrote that you had copied them back in place, but after a fresh new Windows, Firefox and Nightly installation your profile paths are usually different. Is it correct if I assume that you have overwritten files in the new profile directories with files from your backup? If so: Have you considered using the Mozilla Sync feature instead to backup and restore bookmarks, history, addons? It is really convenient to use and designed to be privacy friendly.

But back to the bug. If it is one we would require more information about your system to fix it. Could you please do the following:

1. Navigate to about:config.
2. Set app.update.log to true.
3. Open the About dialog: hamburger menu (☰) -> Help -> About Firefox, wait for the update check and close it again.
4. Open the Browser Console either with the hotkey Control+Shift+j, or via hamburger menu (☰) -> More Tools -> Browser Console
5. In the 'Filter Output' textbox at the top, enter 'AUS' to display all messages related to updates.
6. Select and copy the messages from the Browser Console and attach them to this bug (you can use ``` on the lines before and after to format them correctly)
7. Also please check under about:support that the path for "Dossier pour les mises à jour" differs between Nightly and Firefox and let me know if the paths differ or not.

Comment 3

[[e-mail]]

Thanks for helping Max,
Lets me explain some points (i will try, im french from Canada).
I not install new windows (i have start installed new windows in other hard disk for backup (but not use the new one too much) .
My old windows 10 still work just need remove 1 graphic card of 2, is just non stop reboot my windows.
I do some manipulation in my account name in windows, and i thing the problem start there at January for Firefox and Nighty. both all the type from many month ask they haves update available, when i all ready have it!
I copy my folders of my 2 accounts same way, but at the ending they haves 2 folders with a big long name for separated both Profiles.
I do copy those folders, because Synchronization (haved a problem to connect if windows haved new name computer or profile Name) or import or export from last last more than 20 years i use Firefox, they have some problems (like loose some stuff, OR SETTING! i copied both profiles folders with all files. i started new profiles for both and copied back my files in beside other profiles (not sure now if i pasted old files in the new others profile!
I found new problem from windows or software or router, they cut my speed of internet from 400 Mbps thru around 100 Mbps ou less, this weeks. and found problem, the drivers Windows use from Realtek, block speed, i replace it (forced) and now i having fulll speed. But at same time use a Recovery Point from windows from beginning August to try repair before my speed limits of internet. And when i do that Firefox loose in Button to start, i install back my firefox to Repair, but they put new installation and loosing all stuff. I try many time to connect to Synchronisation and not use files Backups i still haved. and myny time is connect to my account, but not keep, because i know now, Nighty is still connected to same account. I disconnect Nighty in my account Synchronisation, and haved all my stull from my old Firefox. But loosing all my setting Add-ons, and visual setting for Firefox. I update Nighty too, but i connect for first time in my account Synchronisation and change all my stuff in Nighty, because is different profile i hope to keep separate! LOL. But now i haved both Navigator they show is updated, and i thing is now clean, not asking to updated! In Resume, is ok now. But Firefox not repair my older Firefox, Is new installation (because i turn back to August with Windows and scrapt the Firefox information in Windows setting!!! Is like new Firefox with almost my files... AND Nighty is look new, i loose my profile and and bring new profile from Synchronisation of my old Firefox! Now 2 same profile in 2 different Navigator! LOL

Thanks for Helping.

Here the information if you still need:
"05:38:15,331 AUS:SVC Logging current UpdateService status:
05:38:15,331 AUS:SVC UpdateService.canUsuallyCheckForUpdates - able to check for updates
05:38:15,331 AUS:SVC isOtherInstanceRunning - sync manager failed with exception: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIUpdateSyncManager.isOtherInstanceRunning]" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/UpdateService.sys.mjs :: isOtherInstanceRunning :: line 433" data: no]
05:38:15,331 AUS:SVC UpdateService.canCheckForUpdates - able to check for updates
05:38:15,331 AUS:SVC getCanApplyUpdates - testing write access C:\ProgramData\Mozilla-1de4eec8-1241-4177-a864-e594e8d1fb38\updates\308046B0AF4A39CB\update.test
05:38:15,332 AUS:SVC getCanApplyUpdates - unable to apply updates without write access to the update directory. Exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: resource://gre/modules/UpdateService.sys.mjs :: testWriteAccess :: line 530" data: no]
05:38:15,332 AUS:SVC isServiceInstalled - returning true
05:38:15,332 AUS:SVC shouldUseService - returning true
05:38:15,332 AUS:SVC getCanStageUpdates - able to stage updates using the service
05:38:15,332 AUS:SVC Elevation required: false
05:38:15,332 AUS:SVC isOtherInstanceRunning - sync manager failed with exception: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIUpdateSyncManager.isOtherInstanceRunning]" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/UpdateService.sys.mjs :: isOtherInstanceRunning :: line 433" data: no]
05:38:15,332 AUS:SVC Other instance of the application currently running: false
05:38:15,332 AUS:SVC Downloading: false
05:38:15,332 AUS:SVC End of UpdateService status
05:38:32,695 AUS:AUM AppUpdater:check - currentState=STATE_IDLE
05:38:32,695 AUS:SVC isOtherInstanceRunning - sync manager failed with exception: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIUpdateSyncManager.isOtherInstanceRunning]" nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)" location: "JS frame :: resource://gre/modules/UpdateService.sys.mjs :: isOtherInstanceRunning :: line 433" data: no]
05:38:32,695 AUS:AUM AppUpdater:check - starting update check
05:38:32,695 AUS:SVC CheckerService:checkForUpdates - checkType: 2
05:38:32,695 AUS:SVC CheckerService:checkForUpdates - Making new check request for check id 3.
05:38:32,696 AUS:SVC CheckerService:getUpdateURL - checkType: 2
05:38:32,697 AUS:SVC CheckerService:getUpdateURL - update URL: https://aus5.mozilla.org/update/6/Firefox/130.0/20240829075237/WINNT_x86_64-msvc-x64/fr/release/Windows_NT%252010.0.0.0.19045.4780%2520(x64)/ISET%3ASSE4_2%2CMEM%3A31685/default/default/update.xml?force=1
05:38:32,697 AUS:SVC CheckerService:#updateCheck - sending request to: https://aus5.mozilla.org/update/6/Firefox/130.0/20240829075237/WINNT_x86_64-msvc-x64/fr/release/Windows_NT%252010.0.0.0.19045.4780%2520(x64)/ISET%3ASSE4_2%2CMEM%3A31685/default/default/update.xml?force=1
05:38:32,867 AUS:SVC CheckerService:#updateCheck - request got 'load' event
05:38:32,867 AUS:SVC CheckerService:#updateCheck - request completed downloading document
05:38:32,867 AUS:SVC CheckerService:#updateCheck - number of updates available: 0
05:38:32,867 AUS:AUM AppUpdater:check - Update check succeeded
05:38:32,867 AUS:AUM AppUpdater:check - result: NO_UPDATES_FOUND
05:39:07,284 AUS:AUM AppUpdater:stop called "

The Update adress folders is not same:
Nighty:
C:...\updates\6F193CCC56814779
Firefox:
C:...\updates\308046B0AF4A39CB

I saw many crash report in Firefox from last days. Many is not sending, i try to send, but fail! And not know how to copy or saved in files correctly to send here!

Thank you!

Comment 4

[[e-mail]]

New update Saturday, Nighty continue to say they haved update, but already have it!

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mpohle, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Robin Steuber (she/her) [:bytesized]]

Oh dear, this seems to have been dropped.

I cannot read French, but looking at the notification in the top right of the attached image, I am fairly confident that this is this message telling you that Firefox is unable to update. And looking at your log, this makes a lot of sense because of this:

05:38:15,332 AUS:SVC getCanApplyUpdates - unable to apply updates without write access to the update directory. Exception: [Exception... "Component returned failure code: 0x80520015 (NS_ERROR_FILE_ACCESS_DENIED) [nsIFile.create]" nsresult: "0x80520015 (NS_ERROR_FILE_ACCESS_DENIED)" location: "JS frame :: resource://gre/modules/UpdateService.sys.mjs :: testWriteAccess :: line 530" data: no]

As that line states, we cannot update without write access to the update directory. You can see what directory this is by looking for the "Update Folder" row in about:support.

Now, it may be true that you are at the newest version. But it is also true that update is broken. We can't reasonably provide instructions to non-technical users for how to fix update, so their best chance of fixing it is to run the installer, which can fix some update-related issues. So we are doing what we want to do here in the sense that we want to be offering the user the installer in this situation so that we can keep them up-to-date. But our messaging could use some work. That message does say (in English), "Download the new version". And, in this case, that is inaccurate.

I have no idea if running the installer will fix your installation though. From your story, it's not entirely clear to me what state your computer is in, but if your update directory isn't writable, things have gone very wrong. And since I don't know the extent of it, it's hard for me to make a recommendation for how to fix things.

Comment 7

[Monica Chiorean]

Mark as new since it is an enhancement.