Closed Bug 1916159 Opened 1 month ago Closed 1 month ago

51.52 - 2.01% damp complicated.webconsole.close.DAMP / damp console.bulklog + 16 more (Linux) regression on Tue August 27 2024

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a devtools performance regression from push 62bd2a7a9a40e11f3af5fe1c7b0ef5e9a3c87798. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
52% damp complicated.webconsole.close.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 12.15 -> 18.40
20% damp cold.accessibility.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 302.27 -> 363.48
19% damp cold.accessibility.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 300.05 -> 355.62
18% damp custom.netmonitor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 207.43 -> 244.88
15% damp custom.inspector.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 344.78 -> 397.49
13% damp complicated.inspector.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 478.94 -> 538.99
12% damp custom.netmonitor.close.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 21.18 -> 23.72
12% damp simple.styleeditor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 159.88 -> 178.54
12% damp simple.jsdebugger.reload.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 202.91 -> 226.55
12% damp custom.netmonitor.exportHar linux1804-64-shippable-qr e10s fission stylo webrender 536.08 -> 597.84
... ... ... ... ...
6% damp cold.netmonitor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 214.43 -> 227.94
3% damp simple.jsdebugger.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 454.19 -> 466.15
2% damp custom.jsdebugger.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 769.54 -> 788.18
2% damp console.autocomplete linux1804-64-shippable-qr e10s fission stylo webrender 748.84 -> 764.33
2% damp console.bulklog linux1804-64-shippable-qr e10s fission stylo webrender 861.34 -> 878.67

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
17% damp complicated.styleeditor.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 448.50 -> 373.62
4% damp complicated.jsdebugger.open.DAMP linux1804-64-shippable-qr e10s fission stylo webrender 843.23 -> 806.54

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1880

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(gpascutto)

I think a backout was done in Bug 1874689 , so this might just be making those numbers revert back to their baseline

Above comment is correct.

Flags: needinfo?(gpascutto)

(In reply to Gian-Carlo Pascutto [:gcp] from comment #2)

Above comment is correct.

okay, let's close this as invalid then. Thanks!

Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → INVALID

Might be good we verify that our current fix holds on that regression

Changing to fix since it was fixed by the backout

Resolution: INVALID → FIXED
You need to log in before you can comment on or make changes to this bug.