1916199 - [wpt-sync] Sync PR 47923 - [css-nesting] Add CSSNestedDeclarations support for insertRule

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47923 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47923
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

[css-nesting] Add CSSNestedDeclarations support for insertRule

As part of the overall CSSNestedDeclarations change,
the "insert a CSS rule" algorithm [1] now includes a step to retry
parsing of a failed rule as a CSSNestedDeclarations rule [1].
This CL implements that change.

[1] https://drafts.csswg.org/cssom/#insert-a-css-rule

Bug: 343463516
Change-Id: I4b81da404a26cc036a3fcf0aebdbef0775eac0a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5826512
Reviewed-by: Steinar H Gunderson \<[e-mail]>
Commit-Queue: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1349786}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=598f53d34bf16d76452bc3bdea7499508dc84c7d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 12 subtests

Status Summary

Firefox

OK : 1
PASS: 4
FAIL: 8

Chrome

OK : 1
PASS: 10
FAIL: 2

Safari

OK : 1
PASS: 4
FAIL: 8

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-nesting/nested-declarations-cssom.html [wpt.fyi]
  • Trailing declarations: FAIL (Chrome: PASS, Safari: FAIL)
  • Mixed declarations: FAIL (Chrome: PASS, Safari: FAIL)
  • CSSNestedDeclarations.style: FAIL (Chrome: PASS, Safari: FAIL)
  • Nested group rule: FAIL (Chrome: PASS, Safari: FAIL)
  • Nested @scope rule: FAIL (Chrome: PASS, Safari: FAIL)
  • Inner rule starting with an ident: FAIL (Chrome: PASS, Safari: FAIL)
  • Inserting a CSSNestedDeclaration rule into style rule: FAIL (Chrome: FAIL, Safari: FAIL)
  • Inserting a CSSNestedDeclaration rule into nested group rule: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c043990efdf3
[wpt PR 47923] - [css-nesting] Add CSSNestedDeclarations support for insertRule, a=testonly
https://hg.mozilla.org/integration/autoland/rev/ae5d1548db9e
[wpt PR 47923] - Update wpt metadata, a=testonly

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c043990efdf3
https://hg.mozilla.org/mozilla-central/rev/ae5d1548db9e