Closed Bug 1916446 Opened 11 months ago Closed 11 months ago

[wpt-sync] Sync PR 47941 - Replace GetDoubleValue for filter operations

Categories

(Core :: Web Painting, task, P4)

Product:
Core
Component:
Web Painting
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
132 Branch
Tracking Flags:
Tracking Status
firefox132 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47941 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47941
Details from upstream follow.

Daniil Sakhapov <sakhapov@chromium.org> wrote:

Replace GetDoubleValue for filter operations

This CL replaces GetDoubleValue calls with Compute* calls with resolve
data, it also changes InterpolableFilter value to support expressions.

Bug: 40946458
Change-Id: I6f48cdc8282c01af173f3808fb07cb5eb58aa82b
Reviewed-on: https://chromium-review.googlesource.com/5830482
WPT-Export-Revision: 35a3b2acf95d80c960326144c35649b614e09f59

Component: web-platform-tests → Web Painting
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
FAIL : 75

Chrome

CRASH: 2

Safari

OK : 2
PASS : 8
FAIL : 67

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/filter-effects/animation/filter-interpolation-sign-function.html [wpt.fyi]
    • CSS Transitions: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (-1) should be [contrast(20)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0) should be [contrast(100)]: FAIL (Safari: PASS)
    • CSS Transitions: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0.125) should be [contrast(110)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0.875) should be [contrast(170)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (1) should be [contrast(180)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (2) should be [contrast(260)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (-1) should be [contrast(20)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0) should be [contrast(100)]: FAIL (Safari: PASS)
    • CSS Transitions with transition: all: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0.125) should be [contrast(110)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0.875) should be [contrast(170)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (1) should be [contrast(180)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (2) should be [contrast(260)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (-1) should be [contrast(20)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0) should be [contrast(100)]: FAIL (Safari: PASS)
    • CSS Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0.125) should be [contrast(110)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0.875) should be [contrast(170)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (1) should be [contrast(180)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (2) should be [contrast(260)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (-1) should be [contrast(20)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0) should be [contrast(100)]: FAIL (Safari: PASS)
    • Web Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0.125) should be [contrast(110)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (0.875) should be [contrast(170)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (1) should be [contrast(180)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(100)] to [contrast(calc(sign(20rem - 20px) * 180))] at (2) should be [contrast(260)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (-1) should be [hue-rotate(20deg)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0) should be [hue-rotate(100deg)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0.125) should be [hue-rotate(110deg)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0.875) should be [hue-rotate(170deg)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (1) should be [hue-rotate(180deg)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (2) should be [hue-rotate(260deg)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (-1) should be [hue-rotate(20deg)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0) should be [hue-rotate(100deg)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0.125) should be [hue-rotate(110deg)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0.875) should be [hue-rotate(170deg)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (1) should be [hue-rotate(180deg)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (2) should be [hue-rotate(260deg)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (-1) should be [hue-rotate(20deg)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0) should be [hue-rotate(100deg)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0.125) should be [hue-rotate(110deg)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0.875) should be [hue-rotate(170deg)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (1) should be [hue-rotate(180deg)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (2) should be [hue-rotate(260deg)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (-1) should be [hue-rotate(20deg)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0) should be [hue-rotate(100deg)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0.125) should be [hue-rotate(110deg)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (0.875) should be [hue-rotate(170deg)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (1) should be [hue-rotate(180deg)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [hue-rotate(calc(sign(20rem - 20px) * 100deg))] to [hue-rotate(calc(sign(10rem - 10px) * 180deg))] at (2) should be [hue-rotate(260deg)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (-1) should be [contrast(0.02)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0) should be [contrast(0.1)]: FAIL (Safari: PASS)
    • CSS Transitions: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0.125) should be [contrast(0.11)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0.875) should be [contrast(0.17)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (1) should be [contrast(0.18)]: FAIL (Safari: FAIL)
    • CSS Transitions: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (2) should be [contrast(0.26)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (-1) should be [contrast(0.02)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0) should be [contrast(0.1)]: FAIL (Safari: PASS)
    • CSS Transitions with transition: all: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0.125) should be [contrast(0.11)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0.875) should be [contrast(0.17)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (1) should be [contrast(0.18)]: FAIL (Safari: FAIL)
    • CSS Transitions with transition: all: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (2) should be [contrast(0.26)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (-1) should be [contrast(0.02)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0) should be [contrast(0.1)]: FAIL (Safari: PASS)
    • CSS Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0.125) should be [contrast(0.11)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0.875) should be [contrast(0.17)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (1) should be [contrast(0.18)]: FAIL (Safari: FAIL)
    • CSS Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (2) should be [contrast(0.26)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (-1) should be [contrast(0.02)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0) should be [contrast(0.1)]: FAIL (Safari: PASS)
    • Web Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0.125) should be [contrast(0.11)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (0.875) should be [contrast(0.17)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (1) should be [contrast(0.18)]: FAIL (Safari: FAIL)
    • Web Animations: property <filter> from [contrast(0.1)] to [contrast(calc(sign(20rem - 20px) * 18%))] at (2) should be [contrast(0.26)]: FAIL (Safari: FAIL)
  • /css/filter-effects/filter-sign-function.html [wpt.fyi]
    • contrast(calc(sign(1em - 1px) * 2)) should be used-value-equivalent to contrast(2): FAIL (Safari: FAIL)
    • contrast(calc(sign(1em - 1px) * 2%)) should be used-value-equivalent to contrast(2%): FAIL (Safari: FAIL)
    • hue-rotate(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to hue-rotate(2deg): FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb09f9c538e7 [wpt PR 47941] - Replace GetDoubleValue for filter operations, a=testonly https://hg.mozilla.org/integration/autoland/rev/cbb5164f4e9e [wpt PR 47941] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/fb09f9c538e7
https://hg.mozilla.org/mozilla-central/rev/cbb5164f4e9e

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox132: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.