1916508 - VideoEncoder.isConfigSupported with specific config crashes tab

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect, P1)

Description

[jj]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36

Steps to reproduce:

Visit a webpage (with a secure context) which contains the following code:

<script>
    VideoEncoder.isConfigSupported({ codec: 'avc3.42001E', width: 1, height: 1 })
</script>

Relevant crash report: https://crash-stats.mozilla.org/report/index/4ed1a567-9c8d-4523-a4f5-cd1b40240903

Actual results:

The tab crashes.

Expected results:

The tab should not crash.

Comment 1

[Mayank Bansal]

Can confirm.
Bisection:
Bug 1749047 - Bring GetExtraData back to ToMediaRawData r=media-playback-reviewers,padenot

GetExtraData, which is removed in D196209, must be added back to
generate the extra data for H264 AVCC format, so the VideoEncoder can
forward those info with the encoded data.

Differential Revision: https://phabricator.services.mozilla.com/D197138

Comment 2

[Mayank Bansal]

Attachment: Reporters Standalone Testcase.html

Comment 3

[Mayank Bansal]

Attachment: about:support

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1749047

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1916508 - Allow callers to determine if they want h264 codec string parsed stricly or not. r?#media-playback-reviewers

Web Codecs is strict. Other Web APIs aren't.

Comment 6

[Paul Adenot (:padenot)]

Attachment: Bug 1916508 - H264 6.2 exists and is supported on some platforms. r?#media-playback-reviewers

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1916508 - Support "avc3" in h264 codec string. r?#media-playback-reviewers

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1916508 - Align codec string checks in Web Codecs for h264. r?#media-playback-reviewers

To be fixed in Bug 1880326 -- checking is to be lenient in HTMLMediaElement
code (that Web Codecs uses for now, for example, non-existent levels need to be
accepted), and strict in Web Codecs (non-existent levels rejected).

Comment 9

[Paul Adenot (:padenot)]

Attachment: Bug 1916508 - Add more tests about h264 codec strings. r?#media-playback-reviewers

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/695296ac4281
Allow callers to determine if they want h264 codec string parsed stricly or not. r=media-playback-reviewers,alwu
https://hg.mozilla.org/mozilla-central/rev/18d3c3356547
H264 6.2 exists and is supported on some platforms. r=media-playback-reviewers,alwu
https://hg.mozilla.org/mozilla-central/rev/96308ab1e221
Support "avc3" in h264 codec string. r=media-playback-reviewers,alwu
https://hg.mozilla.org/mozilla-central/rev/84d2cd5db84d
Align codec string checks in Web Codecs for h264. r=media-playback-reviewers,alwu
https://hg.mozilla.org/mozilla-central/rev/12b22d6a5e24
Add more tests about h264 codec strings. r=media-playback-reviewers,alwu

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/695296ac4281
https://hg.mozilla.org/mozilla-central/rev/18d3c3356547
https://hg.mozilla.org/mozilla-central/rev/96308ab1e221
https://hg.mozilla.org/mozilla-central/rev/84d2cd5db84d
https://hg.mozilla.org/mozilla-central/rev/12b22d6a5e24

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48271 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot