1916547 - Render Review Checker in the new sidebar

Status: RESOLVED FIXED

(Firefox :: Shopping, task, P3)

Description

[kpatenio]

Unlike Bug 1916017, this ticket is for actually showing the Review Checker panel in the sidebar, if it is enabled via the sidebar's settings.

Comment 1

[Fred Chasen [:fchasen]]

Attachment: Bug 1916547 - Part 1: Render Review Checker in the new sidebar. r?#shopping-reviewers!

Depends on D222380

Comment 2

[Fred Chasen [:fchasen]]

Attachment: WIP: Bug 1916547 - Part 2: Add isProductSite check and pass productSiteUrl to shopping content

Comment 3

[Fred Chasen [:fchasen]]

Attachment: Bug 1916547 - Part 2: Render AboutWelcome in the new sidebar. r?#shopping-reviewers!,#omc-reviewers!

• Adds AboutWelcomeReviewChecker actors for displaying AboutWelcome in the sidebar review checker panel (which isn't an aboutpage).
• AboutWelcomeReviewCheckerParent extends AboutWelcomeParent like the shopping sidebar AboutWelcomeShoppingParent does, but overrides receiveMessage to use embedderElement to get the sidebar browser.
• AboutWelcomeReviewCheckerChild is just a renamed export of AboutWelcomeShoppingChild.

Note prefs set by the message may not work yet since opening and closing the sidebar is per window now and not controlled by the active pref.

Depends on D222840

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/020dc75abd7f
Part 1: Render Review Checker in the new sidebar. r=shopping-reviewers,firefox-desktop-core-reviewers ,sidebar-reviewers,sclements,mossop,kpatenio

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/020dc75abd7f

Comment 6

[Phabricator Automation]

Comment on attachment 9426953 [details]
Bug 1916547 - Part 2: Render AboutWelcome in the new sidebar. r?#shopping-reviewers!,#omc-reviewers!

Revision D223431 was moved to bug 1921570. Setting attachment 9426953 [details] to obsolete.