191681 - a stylesheet of help.xul is loaded twice

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Brant Gurganus]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030131
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030131

The style sheet chrome://communicator/skin is loaded twice.

Reproducible: Always

Steps to Reproduce:
1. Open help.
Actual Results:  
chrome://communicator/skin is loaded twice.

Expected Results:  
chrome://communicator/skin should only load once.

If you look at help.xul, you will see the following lines:
<?xml-stylesheet href="chrome://communicator/skin/help.css" type="text/css"?>
<?xml-stylesheet href="chrome://navigator/skin" type="text/css"?>

If you then open those two URLs, the following line appears in both:
@import url("chrome://communicator/skin/");

I propose that the importation from help.css not be done.

Comment 1

[Brant Gurganus]

Attachment: diffs for XUL skins

I removed the line from both files and added myself to contributor lines.

Comment 2

[Brant Gurganus]

Comment on attachment 113360 [details] [diff] [review]
diffs for XUL skins

requesting review

Comment 3

[Brant Gurganus]

adding applicable keywords and cc'ing Joe Hewitt since he was original author of
those files

Comment 4

[Hermann Schwab]

could that be the reason for bug 184890 hangs when help window opened and
minimized twice ?

Comment 5

[Brant Gurganus]

I don't think so, but then again I am not having that problem.

Comment 6

[Ian Oeschger (gone)]

Comment on attachment 113360 [details] [diff] [review]
diffs for XUL skins

r=oeschger

Comment 7

[Alec Flett]

Comment on attachment 113360 [details] [diff] [review]
diffs for XUL skins

did you get rid of the newline at the end of the file? Make sure its still
there!
sr=alecf

Comment 8

[Ian Oeschger (gone)]

I'll see if I can get this in soon. Thanks, Brant!

Comment 9

[Ian Oeschger (gone)]

FIXED

Comment 10

[R.J. Keller]

VERIFIED.