Open Bug 1916992 Opened 2 years ago Updated 1 year ago

Shorten `DefaultCfrPreferencesRepository.updateCfrPreference`

Categories

(Firefox for Android :: Tooling, task)

Product:
Firefox for Android
Component:
Tooling
Platform:
All
Android
Type:
task

Tracking

()

People

(Reporter: npoon, Unassigned)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group4])

After the CFR pref keys have undergone a renaming and their logic becomes the same / they are all named similarly (aka all of them have the format shouldShow... or ...Shown). Replace updateCfrPreference with the following implementation and also do some adjustments to the repo depending on the new logic:

settings.preferences.edit {
    putBoolean(context.getString(preferenceUpdate.preferenceType.preferenceKey), !preferenceUpdate.value)
}

Searchfox

Assignee: nobody → npoon
Severity: -- → N/A
Status: NEW → ASSIGNED
Depends on: 1910378
Blocks: 1877567
Depends on: 1909337
Whiteboard: [fxdroid][group4]
Blocks: 1924142
No longer blocks: 1877567
Assignee: npoon → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.