Closed Bug 1917176 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 48008 - Additional innertext tests

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
132 Branch
Tracking Flags:
Tracking Status
firefox132 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 48008 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48008
Details from upstream follow.

Ben (MBA M2) <ben@wolkenwelten.net> wrote:

Additional innertext tests

Hey, I've been working on implementing innerText for Servo and noticed that a couple of things aren't tested/specified, so I've added some tests:

  1. <object> content should be ignored for innerText
  2. It wasn't clear whether/how many lines should surround a <p> that's display:block or display:inline-block, both Firefox and Chrome surround them with 2 linebreaks which is a bit suprising, especially for display:inline-block.
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 263 subtests

Status Summary

Firefox

OK : 1
PASS: 254
FAIL: 9

Chrome

OK : 1
PASS: 259
FAIL: 4

Safari

OK : 1
PASS: 172
FAIL: 91

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /html/dom/elements/the-innertext-and-outertext-properties/getter.html [wpt.fyi]
    • <audio> contents ignored ("<audio style='display:block'>abc"): FAIL (Chrome: FAIL, Safari: FAIL)
    • <canvas><div id='target'> contents ok for element not being rendered ("<canvas><div id='target'>abc"): FAIL (Chrome: PASS, Safari: PASS)
    • <select size='1'> contents of options preserved ("<select size='1'><option>abc</option><option>def"): FAIL (Chrome: PASS, Safari: FAIL)
    • empty <optgroup> in <select> ("<div>a<select><optgroup></select>bc"): FAIL (Chrome: PASS, Safari: FAIL)
    • empty <option> in <select> ("<div>a<select><option></select>bc"): FAIL (Chrome: PASS, Safari: FAIL)
    • <optgroup> containing <option> ("<select><optgroup><option>abc</select>"): FAIL (Chrome: PASS, Safari: FAIL)
    • <div> in <option> ("<select><option class='poke-div'>123</select>"): FAIL (Chrome: FAIL, Safari: FAIL)
    • <select size='1'> contents of options preserved ("<div><select size='1'><option>abc</option><option>def"): FAIL (Chrome: PASS, Safari: FAIL)
    • <object> contents ignored ("<div><object>abc"): FAIL (Chrome: PASS, Safari: PASS)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8bb85f7fd490 [wpt PR 48008] - Additional innertext tests, a=testonly https://hg.mozilla.org/integration/autoland/rev/f51caa5bc431 [wpt PR 48008] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8bb85f7fd490
https://hg.mozilla.org/mozilla-central/rev/f51caa5bc431

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox132: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.