1917446 - PR_FormatTimeUSEnglish() doesn't support "%e" format specifier

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Ben Campbell]

PR_FormatTimeUSEnglish() is billed as a locale-ignoring version of strftime(), but it doesn't support "%e" as a format specifier.

From the linux strftime() manpage:

%e     Like  %d,  the  day  of the month as a decimal number, but a leading
              zero is replaced by a space.

Not exactly a big deal, but figured I should log it somewhere!

Comment 1

[Ben Campbell]

And in the interests of leaving breadcrumbs to follow: are the PR_* time functions still considered OK to use, or should people avoid them in favour of something else?

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:KaiE, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Kai Engert [:KaiE:]]

(In reply to Ben Campbell from comment #1)

And in the interests of leaving breadcrumbs to follow: are the PR_* time functions still considered OK to use, or should people avoid them in favour of something else?

Ok to use in C/C++ code. IMHO.

Comment 4

[Kai Engert [:KaiE:]]

Attachment: Bug 1917446 - Add support for %e in PR_FormatTimeUSEnglish. r=BenC

Comment 5

[Kai Engert [:KaiE:]]

Ben, if you want that added, please test and review.

Comment 6

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nspr/rev/488a7a069c8d7405696fd8171ec8fc369834158b