1917548 - Moving tab playing video into new window leaves an orphaned inhibitor that persists until application exit

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Kestrel]

Attachment: Orphaned inhibitor after moving video to new window

STR:

1. Play a video on Ubuntu 24.04.
2. While it is still playing, drag the tab into a new window (or right-click > Move Tab > Move to New Window).
3. Stop the video.
4. Run from terminal:

    dbus-send --print-reply --dest=org.gnome.SessionManager /org/gnome/SessionManager org.gnome.SessionManager.GetInhibitors

5. Repeat steps if it does not occur the first time.

Expected:
Inhibitors list is empty when no videos are playing. Screen goes blank after idle timeout.

Actual:
Inhibitors list has an extra item that is not associated with a playing video. Screen remains on after idle timeout.

Repeating steps produces an orphaned inhibitor each time. Only closing the browser clears the inhibitors list and allows the screen to blank on idle.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0e7c63c931c823b5cc30c784c8c6c1eda03b8eac&tochange=0e96a2dfdd8c67f36e3dabeec9be3cb26f8e2c69

Regressed by Bug 1896235.

Comment 1

[BugBot [:suhaib / :marco]]

:stransky, since you are the author of the regressor, bug 1896235, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1917548 [Linux] Queue screensaver inhibit/uninhibit requests and perform them in order r?emilio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/935617a393ae
[Linux] Queue screensaver inhibit/uninhibit requests and perform them in order r=emilio

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/935617a393ae

Comment 5

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/78c8331a78f1
Backed out changeset 935617a393ae for causing a top crash as in bug 1923641. a=backout

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d98404a9982
[Linux] Queue screensaver inhibit/uninhibit requests and perform them in order r=emilio

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2d98404a9982

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Is this something we want to uplift to Beta before 132 goes to RC on Monday?

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Let's ride it the train.

Comment 11

[Ciprian Georgiu, Desktop QA]

I have reproduced this issue using an affected Nightly build from 2024-09-09, and by following STR detailed in step 0.

The issue is verified as fixed on Ubuntu 24.04 with Firefox 133.0.