1917696 - Publish A New Minor Version of Bergamot WASM From Locally Forked Source

Status: RESOLVED FIXED

(Firefox :: Translations, task, P2)

Description

[Erik Nordin [:nordzilla]]

Description

Once we've forked the browsermt/bergamot-translator source code into tree and trimmed any immediately unnecessary files, we should rebuild our WASM binary from the local fork and publish a new minor version.

This version will be effectively exactly the same as the previous version, but it would be good to test the local fork and its build script(s) end-to-end before we make more invasive modifications to the project.

---

Steps to implement

• Build the WASM binary from the local Bergamot fork.
• Test the WASM binary locally.
• Publish the new WASM binary to Remote Settings with a bumped minor version.
• Test the new WASM binary while it is still in Remote Settings Preview.
• Review and merge the new WASM binary into Remote Settings.

Comment 1

[Erik Nordin [:nordzilla]]

Attachment: Bug 1917696 - Remove patch files from bergamot-translator r=#translations-reviewers!

Now that the source and build logic have been moved upstream in
https://github.com/mozilla/firefox-translations-training/pull/902
we do not need to manually apply patch files to third-party code
here in tree. This removes the entire patches directory.

Comment 2

[Erik Nordin [:nordzilla]]

Attachment: Bug 1917696 - Remove migrated build-bergamot.py functions r=#translations-reviewers!

Now that the source and build logic have been moved upstream in
https://github.com/mozilla/firefox-translations-training/pull/902
much of the functionality within build-bergamot.py has been moved
as well.

This patch removes the functionality of build-bergamot.py that has
been migraged upstream. This leaves build-bergamot.py in an invalid
state that is completed in the next commit, however the following diff
looks much cleaner with these functions already removed.

Depends on D226937

Comment 3

[Erik Nordin [:nordzilla]]

Attachment: Bug 1917696 - Rework build-bergamot.py r=#translations-reviewers!

Now that the source and build logic have been moved upstream in
https://github.com/mozilla/firefox-translations-training/pull/902
we only need to pull the repository and call the build script.

This patch modifies the build-bergamot.py file to pull the upstream
repo and invoke the build scripts, building the Bergamot WASM artifacts
within the specified Docker containers and exporting them into tree.

Depends on D226938

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: Bug 1917696 - Regenerate Bergamot WASM files from new fork r=#translations-reviewers!

Now that the source and build logic have been moved upstream in
https://github.com/mozilla/firefox-translations-training/pull/902
we should regenerate the WASM artifcats using the new infrastructure
to ensure that they are still equivalent and compatible in tree.

This patch runs the scripts to build the new WASM artifacts and stores
them in tree. Independent of this patch, we should publish a new minor
version of the generated WASM binary to Remote Settings.

There shouldn't be any major changes, but we should ensure that everything
is building and running with our current infrastructure.

Depends on D226939

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b81b0ee3ee4b
Remove patch files from bergamot-translator r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/a31aa0b5950b
Remove migrated build-bergamot.py functions r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/69e0cd8b56e5
Rework build-bergamot.py r=translations-reviewers,gregtatum
https://hg.mozilla.org/integration/autoland/rev/64b0099792b8
Regenerate Bergamot WASM files from new fork r=translations-reviewers,gregtatum

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b81b0ee3ee4b
https://hg.mozilla.org/mozilla-central/rev/a31aa0b5950b
https://hg.mozilla.org/mozilla-central/rev/69e0cd8b56e5
https://hg.mozilla.org/mozilla-central/rev/64b0099792b8