1917784 - Implement `TrustedTypePolicyFactory`'s `getPropertyType`

Status: RESOLVED FIXED

(Core :: DOM: Security, task)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

https://w3c.github.io/trusted-types/dist/spec/#dom-trustedtypepolicyfactory-getpropertytype

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Bug 1917784 - Implement `TrustedTypePolicyFactory`'s `getPropertyType`. r=smaug

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Bug 1917784 - Add WPT tests for elementNS parameter of `getPropertyType`. r=smaug

See https://github.com/w3c/trusted-types/issues/429

Comment 3

[Frédéric Wang (:fredw)]

Attachment: Bug 1917784 - Add WPT tests for ASCII case-insensitivity in getPropertyType/getAttributeType. r=smaug

There are already tests for case-insensitivity, but make sure this is
the stronger ASCII case-insensitivity.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4cff581a0df1
Add WPT tests for ASCII case-insensitivity in getPropertyType/getAttributeType. r=smaug
https://hg.mozilla.org/integration/autoland/rev/083738a702c5
Add WPT tests for elementNS parameter of `getPropertyType`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/7bda4dc5eff8
Implement `TrustedTypePolicyFactory`'s `getPropertyType`. r=smaug

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48748 for changes under testing/web-platform/tests

Comment 6

[Atila Butkovits]

Backed out for causing failures at mozilla::dom::DOMString.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b552d57aff8e15b0e8fb0ee686330ee7c55e62ee

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=FOT2tPvPSby262_s7aPo5Q.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7bda4dc5eff8e009bb4d8a73e9accc7256756dbf

Failure log: https://treeherder.mozilla.org/logviewer?job_id=479336480&repo=autoland&lineNumber=2502

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Frédéric Wang (:fredw)]

Y(In reply to Atila Butkovits from comment #6)

Backed out for causing failures at mozilla::dom::DOMString.

The assert is because we cannot call SetKnownLiveString after SetNull: https://searchfox.org/mozilla-central/rev/dfc3050503739883ce6d17e8365bc35410106aba/dom/bindings/DOMString.h#34 ; fixed in the latest version.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/186050bf0ca6
Add WPT tests for ASCII case-insensitivity in getPropertyType/getAttributeType. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f8cb9e794fee
Add WPT tests for elementNS parameter of `getPropertyType`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/65f3d238048d
Implement `TrustedTypePolicyFactory`'s `getPropertyType`. r=smaug

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/186050bf0ca6
https://hg.mozilla.org/mozilla-central/rev/f8cb9e794fee
https://hg.mozilla.org/mozilla-central/rev/65f3d238048d

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 12

[Donal Meehan [:dmeehan]]

:fredw do you want to nominate this for a release note? (Process info)

Comment 13

[Frédéric Wang (:fredw)]

I think this is only a small method from the Trusted Types spec, so probably not worth nominating it.

Comment 14

[Hamish Willee]

FF133 MDN docs for this can be tracked in https://github.com/mdn/content/issues/36559. As this is very minimal implementation, mostly that is just a compatibility data update, and an experimental features doc section that just makes it clear that there is a lot more to come (essentially, a placeholder). The method already has documentation.