1917847 - Remove "extensions.ui.installDialogFullDomains" pref introduced by Bug 1911163 as a rollback pref

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As part of Bug 1911163 patches we are introducing a new pref (currently named "extensions.ui.installDialogFullDomains") to be able to roll back to the previous version of the addon install and optional permissions where the domains where not all listed in the dialog if we need to (e.g. if QA reports us an issue hit on beta that needs to be fixed before letting the updated dialog to get to the release channel).

A couple of cycles after the new dialog design got shipped to the release channel we should remove the pref and cleanup logic and fluent strings that would become unreachable / unused.

In particular, in addition to cleaning up the logic from the ExtensionData's formatPermissionString static method, the following fluent ids from extensions.ftl would become unreachable/unused and should be removed:

• webext-perms-host-description-wildcard
• webext-perms-host-description-too-many-wildcards
• webext-perms-host-description-one-site
• webext-perms-host-description-too-many-sites

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1917847 - Remove "extensions.ui.installDialogFullDomains" pref, r?rpl

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a438ac70a97
Remove "extensions.ui.installDialogFullDomains" pref, r=rpl

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3a438ac70a97