1917850 - SearchEngineSelector.fetchEngineConfiguration could be explicit about returning the default engine

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Mark Banner (:standard8)]

Currently SearchEngineSelector.fetchEngineConfiguration returns a list of engines, and the application default private engine. It is assumed that the application default normal mode engine is the first item in the list.

Although the order rules say that it will be first, I think it is better to be explicit and it saves having to have that knowledge elsewhere in the code.

Whilst we're here, we can also raise explicit errors if there's no default engine found, or if there's no engines at all. This will help us be more explicit about failure situations and actually manages to find some issues in tests.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1917850 - SearchEngineSelector.fetchEngineConfiguration chould be explicit about returning the default engine. r?mcheang!

Also makes fetchEngineConfiguration log or throw errors if it can't find a default engine / all engines.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/533955f713e4
SearchEngineSelector.fetchEngineConfiguration chould be explicit about returning the default engine. r=mcheang

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/533955f713e4