1917873 - [wmfme] Incorrect keyid when using the media foundation CDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Alastor Wu [:alwu]]

STR.

1. go to https://reference.dashif.org/dash.js/latest/samples/drm/playready.html
2. check MediaKeySession.keyStatuses

Expected.
3. keyid should be 87936e2dca604541aec2c40837b4b026 and 519e028b6ad5bd44910fd4b5fd90fba2 and their status should be usable

Actual.
3. incorrect keyids and some of them even show status-pending

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1917873 - part1 : cast to correct type to fix the conversion result.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1917873 - part2 : add debug logs.

Depends on D221697

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1917873 - part3 : check key Id and status in test.

This patch allows us to check non-GUID keyid in our test to ensure the
key is equal to the one set in the init data.

Depends on D221698

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c82fc68684e4
part1 : cast to correct type to fix the conversion result. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/acf167a789d8
part2 : add debug logs. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/f073db877894
part3 : check key Id and status in test. r=media-playback-reviewers,padenot

Comment 5

[tszentpeteri]

Backed out for causing bpnu bustages on MFCDMSession.cpp.

• Backout link
• Push with failures
• Failure Log:

[task 2024-09-10T22:06:00.355Z] 22:06:00     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/platforms/wmf'
[task 2024-09-10T22:06:00.358Z] 22:06:00     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang-cl -fms-compatibility-version=19.39 -std:c++17 -Xclang -ivfsoverlay -Xclang /builds/worker/fetches/vs/overlay.yaml -FoMFCDMSession.obj -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -guard:cf -DNDEBUG=1 -DTRIMMED=1 -DUNICODE -D_UNICODE -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -D_SECURE_ATL -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DWIN32 -D_WIN32 -D_WINDOWS -DWIN32_LEAN_AND_MEAN -DWINAPI_NO_BUNDLED_LIBRARIES -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DMOZ_SUPPORT_LEAKCHECKING -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/dom/media/platforms/wmf -I/builds/worker/workspace/obj-build/dom/media/platforms/wmf -I/builds/worker/checkouts/gecko/dom/media/ipc -I/builds/worker/checkouts/gecko/gfx/cairo/cairo/src -I/builds/worker/checkouts/gecko/media/libyuv/libyuv/include -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -MD -DMOZILLA_CLIENT -FI /builds/worker/workspace/obj-build/mozilla-config.h -Zc:sizedDealloc- -Gy -Zc:inline -Gw -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -TP -GR- -D_HAS_EXCEPTIONS=0 -fcrash-diagnostics-dir=/builds/worker/artifacts -Z7 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -Werror -W3 -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wvolatile -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-microsoft-exception-spec -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -Wno-psabi -Wthread-safety -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -fno-strict-aliasing -Xclang -ffp-contract=off  -Xclang -MP -Xclang -dependency-file -Xclang .deps/MFCDMSession.obj.pp -Xclang -MT -Xclang MFCDMSession.obj   /builds/worker/checkouts/gecko/dom/media/platforms/wmf/MFCDMSession.cpp
[task 2024-09-10T22:06:00.359Z] 22:06:00    ERROR -  /builds/worker/checkouts/gecko/dom/media/platforms/wmf/MFCDMSession.cpp(237,20): error: no member named 'media_eme_wmf_use_mock_cdm_for_external_cdms' in namespace 'mozilla::StaticPrefs'
[task 2024-09-10T22:06:00.359Z] 22:06:00     INFO -    237 |       StaticPrefs::media_eme_wmf_use_mock_cdm_for_external_cdms();
[task 2024-09-10T22:06:00.359Z] 22:06:00     INFO -        |       ~~~~~~~~~~~~~^
[task 2024-09-10T22:06:00.359Z] 22:06:00     INFO -  1 error generated.
[task 2024-09-10T22:06:00.359Z] 22:06:00    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:675: MFCDMSession.obj] Error 1
[task 2024-09-10T22:06:00.359Z] 22:06:00     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/dom/media/platforms/wmf'
[task 2024-09-10T22:06:00.368Z] 22:06:00     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/dom/media/platforms/wmf'

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca807a3c550c
part1 : cast to correct type to fix the conversion result. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/b27a5c1c02fb
part2 : add debug logs. r=media-playback-reviewers,padenot
https://hg.mozilla.org/integration/autoland/rev/87d228a54c24
part3 : check key Id and status in test. r=media-playback-reviewers,padenot

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/ca807a3c550c
https://hg.mozilla.org/mozilla-central/rev/b27a5c1c02fb
https://hg.mozilla.org/mozilla-central/rev/87d228a54c24