Closed Bug 1917974 Opened 1 year ago Closed 9 months ago

Add support for sending header Available-Dictionary

Tracking

()

Status:

RESOLVED FIXED

Milestone:

145 Branch

Tracking Flags:

Tracking

Status

firefox145

---

fixed

People

(Reporter: jesup, Assigned: jesup)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(7 files, 1 obsolete file)

Bug 1917974: Accumulate Dictionary hash values r=#necko-reviewers! 1 year ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1917974: Accumulate Dictionary hash values r=#necko-reviewers! 1 year ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1917974: Make GetDictionaryFor async since we need to query the cache r=#necko-reviewers! 1 year ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1917974: Add OnCacheEntryCallbacks for Compression Dictionaries r=#necko-reviewers! 1 year ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1917974: Hook in Prefetching of cache entries for Compression Dictionaries r=#necko-reviewers! 1 year ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1917974: Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=#necko-reviewers! 1 year ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1917974: Clean up call to GetDictionaryFor() r=valentin! 10 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=#necko-reviewers!,#devtools-reviewers! 10 months ago Randell Jesup [:jesup] (needinfo me) 48 bytes, text/x-phabricator-request		Details \| Review

Randell Jesup [:jesup] (needinfo me)

Assignee

Description

•

1 year ago

Only for HTTPS, if we have an available dictionary

Randell Jesup [:jesup] (needinfo me)

Assignee

Updated

•

1 year ago

Depends on: 1917975

Randell Jesup [:jesup] (needinfo me)

Assignee

Updated

•

1 year ago

Depends on: 1917976

Randell Jesup [:jesup] (needinfo me)

Assignee

Updated

•

1 year ago

Depends on: 1917979

Randell Jesup [:jesup] (needinfo me)

Assignee

Updated

•

1 year ago

Severity: -- → S3

Priority: -- → P2

Whiteboard: [necko-triaged]

Randell Jesup [:jesup] (needinfo me)

Assignee

Updated

•

1 year ago

Depends on: 1949981

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 1

•

1 year ago

Attached file Bug 1917974: Accumulate Dictionary hash values r=#necko-reviewers! (obsolete) — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 2

•

1 year ago

Attached file Bug 1917974: Accumulate Dictionary hash values r=#necko-reviewers! — Details

Phabricator Automation

Updated

•

1 year ago

Attachment #9501980 - Attachment is obsolete: true

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 3

•

1 year ago

Attached file Bug 1917974: Make GetDictionaryFor async since we need to query the cache r=#necko-reviewers! — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 4

•

1 year ago

Attached file Bug 1917974: Add OnCacheEntryCallbacks for Compression Dictionaries r=#necko-reviewers! — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 5

•

1 year ago

Attached file Bug 1917974: Hook in Prefetching of cache entries for Compression Dictionaries r=#necko-reviewers! — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 6

•

1 year ago

Attached file Bug 1917974: Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=#necko-reviewers! — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 7

•

10 months ago

Attached file Bug 1917974: Clean up call to GetDictionaryFor() r=valentin! — Details

Randell Jesup [:jesup] (needinfo me)

Assignee

Comment 8

•

10 months ago

Attached file Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=#necko-reviewers!,#devtools-reviewers! — Details

We need to do this before we save the headers in the CacheEntry

Phabricator Automation

Updated

•

9 months ago

Attachment #9514164 - Attachment description: Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=#necko-reviewers! → Bug 1917974: Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=#necko-reviewers!,#devtools-reviewers!

Pulsebot

Comment 9

•

9 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e51d5b97d842 https://hg.mozilla.org/integration/autoland/rev/d91479f107a0 Accumulate Dictionary hash values r=necko-reviewers,sunil https://github.com/mozilla-firefox/firefox/commit/f9141e066c58 https://hg.mozilla.org/integration/autoland/rev/17721b09beb2 Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/7cab0d4a557d https://hg.mozilla.org/integration/autoland/rev/7e26f6a37980 Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/66d6a7822d9a https://hg.mozilla.org/integration/autoland/rev/3ef3e2fbf17d Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/695c5efddd51 https://hg.mozilla.org/integration/autoland/rev/e344574470b4 Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/b62c076aa437 https://hg.mozilla.org/integration/autoland/rev/c83ba17382d4 Clean up call to GetDictionaryFor() r=valentin,necko-reviewers https://github.com/mozilla-firefox/firefox/commit/1e9c6f213239 https://hg.mozilla.org/integration/autoland/rev/7ee6cda2d42d Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy

Sandor Molnar[:smolnar]

Comment 10

•

9 months ago

Backed out for causing multiple bustages/failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/837a3d407e1c473641116eb9e1a150237c764645

Push with failures

Failure log -> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/netwerk/test/unit/test_dictionary_storage.js:595:9 | 'headerValue' is assigned a value but never used. (no-unused-vars)

Failure log -> ERROR - /builds/worker/checkouts/gecko/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:358:23: error: format '%d' expects argument of type 'int', but argument 4 has type 'nsresult' [-Werror=format=]

Failure log -> ERROR - /builds/worker/workspace/obj-build/dist/include/mozilla/net/Dictionary.h:313:14: error: unused variable 'rv' [-Werror,-Wunused-variable]

Failure log -> TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_trr.js | test_server_up - [test_server_up : 84] "undefined" == "Error: could not find id"

Failure log -> TEST-UNEXPECTED-FAIL | /service-workers/service-worker/worker-interception.https.html

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_copy_headers.js | Timed out while polling clipboard for requested data

Flags: needinfo?(rjesup)

Cristian Tuns

Comment 11

•

9 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d91479f107a0
https://hg.mozilla.org/mozilla-central/rev/17721b09beb2
https://hg.mozilla.org/mozilla-central/rev/7e26f6a37980
https://hg.mozilla.org/mozilla-central/rev/3ef3e2fbf17d
https://hg.mozilla.org/mozilla-central/rev/e344574470b4
https://hg.mozilla.org/mozilla-central/rev/c83ba17382d4
https://hg.mozilla.org/mozilla-central/rev/7ee6cda2d42d

Status: NEW → RESOLVED

Closed: 9 months ago

status-firefox145: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 145 Branch

Takanori MATSUURA

Updated

•

9 months ago

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

BugBot [:suhaib / :marco/ :calixte]

Updated

•

9 months ago

status-firefox145: fixed → affected

Pulsebot

Comment 12

•

9 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/015daa433c3d https://hg.mozilla.org/integration/autoland/rev/2b48ea0ffc38 Accumulate Dictionary hash values r=necko-reviewers,sunil https://github.com/mozilla-firefox/firefox/commit/a7a392618669 https://hg.mozilla.org/integration/autoland/rev/34b60ebf761b Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/f98d53f3d856 https://hg.mozilla.org/integration/autoland/rev/eee0bbfac0d3 Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/92e5123e802f https://hg.mozilla.org/integration/autoland/rev/78ab93da6102 Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/b112c8033c70 https://hg.mozilla.org/integration/autoland/rev/7ea97de376b9 Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/e2a5d4310ed1 https://hg.mozilla.org/integration/autoland/rev/da9a42cd0d2c Clean up call to GetDictionaryFor() r=valentin,necko-reviewers https://github.com/mozilla-firefox/firefox/commit/f358804607d0 https://hg.mozilla.org/integration/autoland/rev/bc0389d861e1 Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy

amarc

Comment 13

•

9 months ago

Backed out for causing multiple failures

Pulsebot

Comment 14

•

9 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ea0cf241875b https://hg.mozilla.org/integration/autoland/rev/1af369173efb Accumulate Dictionary hash values r=necko-reviewers,sunil https://github.com/mozilla-firefox/firefox/commit/7e8b87dc92b3 https://hg.mozilla.org/integration/autoland/rev/bbaa1069d53b Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/685cec0da4f8 https://hg.mozilla.org/integration/autoland/rev/41a50c6dd1fb Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/5b21f619d78a https://hg.mozilla.org/integration/autoland/rev/4e288e4f46ec Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/31007cf1b07f https://hg.mozilla.org/integration/autoland/rev/3eb2d0892aeb Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin

Pulsebot

Comment 15

•

9 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/33dee2c19859 https://hg.mozilla.org/integration/autoland/rev/706f854ba7e9 Accumulate Dictionary hash values r=necko-reviewers,sunil https://github.com/mozilla-firefox/firefox/commit/a6a46a545835 https://hg.mozilla.org/integration/autoland/rev/2acc269797d6 Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/3ce506bc4b61 https://hg.mozilla.org/integration/autoland/rev/405d19435af8 Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/8dc5e144c188 https://hg.mozilla.org/integration/autoland/rev/f9f786831423 Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/f3209510773d https://hg.mozilla.org/integration/autoland/rev/05564dff93e3 Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/97c3a788a8f7 https://hg.mozilla.org/integration/autoland/rev/e7abfc8199f8 Clean up call to GetDictionaryFor() r=valentin,necko-reviewers https://github.com/mozilla-firefox/firefox/commit/f178e71d24a3 https://hg.mozilla.org/integration/autoland/rev/82cd7ab83408 Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy

Pulsebot

Comment 16

•

9 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ed3b6cd3eccd https://hg.mozilla.org/integration/autoland/rev/d862b1809070 Accumulate Dictionary hash values r=necko-reviewers,sunil https://github.com/mozilla-firefox/firefox/commit/719a8a0e6163 https://hg.mozilla.org/integration/autoland/rev/f0b3cc8f7856 Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/179b725f1632 https://hg.mozilla.org/integration/autoland/rev/72a61e9bec09 Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/c9e18bdf3b9c https://hg.mozilla.org/integration/autoland/rev/b196f9a679b8 Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/aabfdecb3a62 https://hg.mozilla.org/integration/autoland/rev/5ebc0e244669 Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/dd77492425eb https://hg.mozilla.org/integration/autoland/rev/dc33352c80d1 Clean up call to GetDictionaryFor() r=valentin,necko-reviewers https://github.com/mozilla-firefox/firefox/commit/1c5e6866db14 https://hg.mozilla.org/integration/autoland/rev/74b70f93e070 Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy

Cristian Tuns

Comment 17

•

9 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d862b1809070
https://hg.mozilla.org/mozilla-central/rev/f0b3cc8f7856
https://hg.mozilla.org/mozilla-central/rev/72a61e9bec09
https://hg.mozilla.org/mozilla-central/rev/b196f9a679b8
https://hg.mozilla.org/mozilla-central/rev/5ebc0e244669
https://hg.mozilla.org/mozilla-central/rev/dc33352c80d1
https://hg.mozilla.org/mozilla-central/rev/74b70f93e070

Status: REOPENED → RESOLVED

Closed: 9 months ago → 9 months ago

status-firefox145: affected → fixed

Resolution: --- → FIXED

Atila Butkovits

Comment 18

•

9 months ago

Backed out for causing failures /dictionary-compressed.tentative.https.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/339cb96b8aea9a433abdfee35eca4472ecb7074e

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=windows%2C11%2Cx86%2C24h2%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows11-32-24h2%2Fopt-web-platform-tests%2Cwpt12&revision=f63dea815067f6fefbac80cce46e1a0589f66a31&selectedTaskRun=OXPZFu52Tyq66R0qicmggw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=529651894&repo=autoland&task=OXPZFu52Tyq66R0qicmggw.0&lineNumber=10724

Status: RESOLVED → REOPENED

status-firefox145: fixed → ---

Resolution: FIXED → ---

Target Milestone: 145 Branch → ---

Pulsebot

Comment 19

•

9 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5cdbe885bc5e https://hg.mozilla.org/integration/autoland/rev/ca1fba809777 Accumulate Dictionary hash values r=necko-reviewers,sunil https://github.com/mozilla-firefox/firefox/commit/33cb96b72fdf https://hg.mozilla.org/integration/autoland/rev/abb6787dfdc7 Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/e59973005042 https://hg.mozilla.org/integration/autoland/rev/5b579fd0d4ed Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/77f0cd19123f https://hg.mozilla.org/integration/autoland/rev/4a868eda35c3 Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/5076f7a779f5 https://hg.mozilla.org/integration/autoland/rev/75262eaebe10 Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/b4d8ad3a3404 https://hg.mozilla.org/integration/autoland/rev/4bcc98647f77 Clean up call to GetDictionaryFor() r=valentin,necko-reviewers https://github.com/mozilla-firefox/firefox/commit/df63d60f8fea https://hg.mozilla.org/integration/autoland/rev/836e94040a2a Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy

Pulsebot

Comment 20

•

9 months ago

Pushed by rjesup@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/06974fe1c159 https://hg.mozilla.org/integration/autoland/rev/97a14f3453bb Accumulate Dictionary hash values r=necko-reviewers,sunil https://github.com/mozilla-firefox/firefox/commit/7aa0d292934a https://hg.mozilla.org/integration/autoland/rev/f7c7753731e5 Make GetDictionaryFor async since we need to query the cache r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/d6a115c0a50f https://hg.mozilla.org/integration/autoland/rev/3f9ce7966e83 Add OnCacheEntryCallbacks for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/eacd93da22cb https://hg.mozilla.org/integration/autoland/rev/31e6ead3d29d Hook in Prefetching of cache entries for Compression Dictionaries r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/f014fa8be1bc https://hg.mozilla.org/integration/autoland/rev/c82738a84a45 Add OPEN_COMPLETE_ONLY and use it for Compression Dictionary Prefetch r=necko-reviewers,valentin https://github.com/mozilla-firefox/firefox/commit/7cf9370775df https://hg.mozilla.org/integration/autoland/rev/bddf89265912 Clean up call to GetDictionaryFor() r=valentin,necko-reviewers https://github.com/mozilla-firefox/firefox/commit/93865a01eaa6 https://hg.mozilla.org/integration/autoland/rev/ae0ebc799a43 Move CompressionDictionaries AddAcceptAndDictionaryHeaders to run earlier r=necko-reviewers,kershaw,devtools-reviewers,bomsy

pstanciu

Comment 21

•

9 months ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/97a14f3453bb
https://hg.mozilla.org/mozilla-central/rev/f7c7753731e5
https://hg.mozilla.org/mozilla-central/rev/3f9ce7966e83
https://hg.mozilla.org/mozilla-central/rev/31e6ead3d29d
https://hg.mozilla.org/mozilla-central/rev/c82738a84a45
https://hg.mozilla.org/mozilla-central/rev/bddf89265912
https://hg.mozilla.org/mozilla-central/rev/ae0ebc799a43

Status: REOPENED → RESOLVED

Closed: 9 months ago → 9 months ago

status-firefox145: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 145 Branch

Randell Jesup [:jesup] (needinfo me)

Assignee

Updated

•

9 months ago

Flags: needinfo?(rjesup)

Mihai Boldan, Desktop QA [:mboldan]

Updated

•

9 months ago

QA Whiteboard: [qa-triage-done-c146/b145]

Mathew Hodson

Updated

•

6 months ago

No longer depends on: 1917979