1917991 - Implementation for highlightsFromPoint API

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Stephanie Zhang]

Steps to reproduce:

Filing this bug to track the implementation of the "highlightsFromPoint" API.

Mozilla Standards Position: https://github.com/mozilla/standards-positions/issues/1068

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1917991, part 1.1 - HighlightsFromPoint: Move GetClientRect into AbstractRange: Move`RangeSubtreeIterator` into `ContentIterator` file. r=emilio!

Comment 2

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1917991, part 1.2 - HighlightsFromPoint: Move GetClientRect() into AbstractRange. r=emilio!

This patch does not change any logic, it just
moves code, so that it can be used AbstractRange
as well as from nsRange.

Comment 3

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1917991, part 2 - HighlightsFromPoint: Implement webidl interface. r=emilio!

Comment 4

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1917991, part 3 - HighlightsFromPoint: Implement `HighlightsFromPoint()`. r=emilio!

Comment 5

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1917991, part 1.3 - HighlightsFromPoint: Add range iteration interface to `DOMRectList`. r=emilio!

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:jjaschke, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 7

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1917991, part 4 - HighlightsFromPoint: Add more test cases. r=emilio!

Test collapsed ranges, invalid StaticRanges, and overlapping ranges within the same highlight.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c569a79572e
https://hg.mozilla.org/integration/autoland/rev/4b50c5314d35
part 1.1 - HighlightsFromPoint: Move GetClientRect into AbstractRange: Move`RangeSubtreeIterator` into `ContentIterator` file. r=emilio
https://github.com/mozilla-firefox/firefox/commit/10c28cc41090
https://hg.mozilla.org/integration/autoland/rev/a437ad29a927
part 1.2 - HighlightsFromPoint: Move GetClientRect() into AbstractRange. r=emilio
https://github.com/mozilla-firefox/firefox/commit/be1f3a6f50d2
https://hg.mozilla.org/integration/autoland/rev/140b42d7b91b
part 2 - HighlightsFromPoint: Implement webidl interface. r=emilio,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/6b88681d6426
https://hg.mozilla.org/integration/autoland/rev/8783b1dad258
part 3 - HighlightsFromPoint: Implement `HighlightsFromPoint()`. r=emilio
https://github.com/mozilla-firefox/firefox/commit/53c20dba9cb7
https://hg.mozilla.org/integration/autoland/rev/41e1394d53b7
part 4 - HighlightsFromPoint: Add more test cases. r=emilio

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58209 for changes under testing/web-platform/tests

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9075bc6e1706
https://hg.mozilla.org/integration/autoland/rev/8666bbfb98e0
Revert "Bug 1917991, part 4 - HighlightsFromPoint: Add more test cases. r=emilio" for causing bustages at Highlight.cpp.

Comment 11

[Atila Butkovits]

Backed out for causing bustages at Highlight.cpp.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/8666bbfb98e085e8611430b553b796bdc8c120cd

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=SJCQoT1_Qm6YNuglVGc2qw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=41e1394d53b7c51c01ab295615af29806dde466d

Failure log: https://treeherder.mozilla.org/logviewer?job_id=551612290&repo=autoland&task=SJCQoT1_Qm6YNuglVGc2qw.0&lineNumber=68613

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/25d713905913
https://hg.mozilla.org/integration/autoland/rev/fcfe17b7e0e7
part 1.1 - HighlightsFromPoint: Move GetClientRect into AbstractRange: Move`RangeSubtreeIterator` into `ContentIterator` file. r=emilio
https://github.com/mozilla-firefox/firefox/commit/525057feab71
https://hg.mozilla.org/integration/autoland/rev/bdaf498163df
part 1.2 - HighlightsFromPoint: Move GetClientRect() into AbstractRange. r=emilio
https://github.com/mozilla-firefox/firefox/commit/456c803c3e3c
https://hg.mozilla.org/integration/autoland/rev/609d1534fc42
part 2 - HighlightsFromPoint: Implement webidl interface. r=emilio,webidl,smaug
https://github.com/mozilla-firefox/firefox/commit/c041a52c4b15
https://hg.mozilla.org/integration/autoland/rev/0555bd0d1f1d
part 3 - HighlightsFromPoint: Implement `HighlightsFromPoint()`. r=emilio
https://github.com/mozilla-firefox/firefox/commit/9a23fe76ca0f
https://hg.mozilla.org/integration/autoland/rev/8222648764f1
part 4 - HighlightsFromPoint: Add more test cases. r=emilio

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/fcfe17b7e0e7
https://hg.mozilla.org/mozilla-central/rev/bdaf498163df
https://hg.mozilla.org/mozilla-central/rev/609d1534fc42
https://hg.mozilla.org/mozilla-central/rev/0555bd0d1f1d
https://hg.mozilla.org/mozilla-central/rev/8222648764f1

Comment 14

[Dianna Smith [:diannaS]]

:jjaschke is this something you want to mention in the Fx150 release notes? Feel free to nominate if so.

Comment 15

[Jan Jaeschke [:jjaschke]]

Release Note Request (optional, but appreciated)
[Why is this notable]: highlightsFromPoint() allows web pages to interact with CSS Highlights by returning all Highlights at a given point.
[Affects Firefox for Android]: Yes
[Suggested wording]:
[Links (documentation, blog post, etc)]: MDN

Comment 16

[Dianna Smith [:diannaS]]

Added to the Fx150 release notes https://www.firefox.com/en-US/firefox/150.0a1/releasenotes/

Comment 17

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 18

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging