1918241 - Add for an `eq` function to the setPositionContentMarker API

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Hubert Boma Manilla (:bomsy)]

The eq function for the createPositionContentMarkersExtension stops updates of the column breakpoints. This is because the eq function here currently does not check the changes in the breakpoint object from here.

Lets maybe add a way to define an eq function for the setPositionContentMarker API, which should help handle this.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1918241 - [devtools] Add custom equality function to specify granular criteria for position marker widget updates r=#devtools-reviewers

This fixes the issue where column breakpoints are not updated on click.
Fixes browser_dbg-breakpoints-columns.js for CM6

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/398f6bc67c2e
[devtools] Add custom equality function to specify granular criteria for position marker widget updates r=devtools-reviewers,nchevobbe

Comment 3

[tszentpeteri]

Backed out for causing dt failures related to browser_dbg.

• Backout link
• Push with failures
• Failure Log 1
• Failure Log 2
• Failure Log 3
• Failure Log 4
• Failure Log 5
• Failure Log 6
• Failure Log 7

[task 2024-10-10T07:14:20.002Z] 07:14:20     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-editor-scroll.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2024-10-10T07:14:20.002Z] 07:14:20     INFO - finish() was called, cleaning up and clearing debugger preferences...
[task 2024-10-10T07:14:20.002Z] 07:14:20     INFO - Buffered messages finished
[task 2024-10-10T07:14:20.003Z] 07:14:20     INFO - TEST-UNEXPECTED-PASS | devtools/client/debugger/test/mochitest/browser_dbg-editor-scroll.js | We expect at least one assertion to fail because this test file is marked as fail-if in the manifest. - 
[task 2024-10-10T07:14:20.003Z] 07:14:20     INFO - TEST-INFO | expected FAIL
[task 2024-10-10T07:14:20.003Z] 07:14:20     INFO - GECKO(1066) | MEMORY STAT | vsize 12638MB | residentFast 788MB | heapAllocated 436MB
[task 2024-10-10T07:14:20.004Z] 07:14:20     INFO - TEST-OK | devtools/client/debugger/test/mochitest/browser_dbg-editor-scroll.js | took 2765ms
[task 2024-10-10T07:14:20.004Z] 07:14:20     INFO - checking window state
[task 2024-10-10T07:14:20.005Z] 07:14:20     INFO - TEST-START | devtools/client/debugger/test/mochitest/browser_dbg-editor-select.js

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88286849fa11
[devtools] Add custom equality function to specify granular criteria for position marker widget updates r=devtools-reviewers,nchevobbe

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/88286849fa11