1918310 - mroot and msqrt should share their implementation

Status: RESOLVED FIXED

(Core :: MathML, task)

Description

[Frédéric Wang Nélar]

That used to be the case, until I implemented menclose (which accepted the notation="radical" notation). notation="radical" was removed in bug 1548522, so it makes more sense for msqrt to share the implementation with mroot.

MathML Core actually does that by wrapping the children of msqrt in an anonymous mrow:
https://w3c.github.io/mathml-core/#radicals-msqrt-mroot

The <msqrt> element generates an anonymous <mrow> box called the msqrt base.

Comment 1

[Frédéric Wang Nélar]

Attachment: Bug 1918310 - Make mroot and msqrt should share their implementation. r=emilio

Comment 2

[Frédéric Wang Nélar]

Attachment: Bug 1918310 - Remove class nsMathMLmsqrtFrame. r=emilio

This class is currently only used:

• To override InheritAutomaticData(), we move that directly in
  nsMathMLrootFrame. Probably we should do that too when
  ShouldUseRowFallback() returns true, but this patch does not try and
  change current behavior.

• To override IsMrowLike(), but it's actually doing exactly the same as
  nsMathMLContainerFrame and nsMathMLmrootFrame does not override it.
  Again, these implementations are likely wrong, but we keep current
  behavior.

Comment 3

[Frédéric Wang Nélar]

https://treeherder.mozilla.org/jobs?repo=try&revision=7512a2aacf5b4295656e15091fa8b7ca0c58e083

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5df0457b5b41
Make mroot and msqrt should share their implementation. r=emilio
https://hg.mozilla.org/integration/autoland/rev/b5768f9d9c6b
Remove class nsMathMLmsqrtFrame. r=emilio

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5df0457b5b41
https://hg.mozilla.org/mozilla-central/rev/b5768f9d9c6b