Closed Bug 191836 Opened 22 years ago Closed 21 years ago

cookiesTree in CookieViewer.xul should use seltype attribute

Categories

(Core :: Networking: Cookies, defect)

Product:
Core
Component:
Networking: Cookies
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: bugzilla, Assigned: skasinathan)

Details

Attachments

(2 files, 1 obsolete file)

patch.
1.22 KB, patch
janv
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review
New patch for v1.63
1.32 KB, patch
janv
: review+
jag+mozilla
: superreview+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2) Gecko/20021126
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2) Gecko/20021126

The tree "cookiesTree" in CookieViewer.xul is the last place to use the
multiple="true" attribute instead of the seltype="multiple" attribute to allow
multiple item selection.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Attached patch patch (obsolete) — — Splinter Review 

    
    

    
  
-> suresh
Assignee: darin → suresh

    
    

    
  
The tree element supports multiple selection by default. There is no need to
explicitly say this in xul.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch.
        — 
          — Splinter Review
      

    


  

        Attachment #113473 -
        Attachment is obsolete: true

    
  

        Attachment #113513 -
        Flags: superreview?(jaggernaut)

        Attachment #113513 -
        Flags: review?(varga)

    
    

    
  
Comment on attachment 113513 [details] [diff] [review]
patch.

sr=jag

        Attachment #113513 -
        Flags: superreview?(jaggernaut) → superreview+

    
    

    
  
Comment on attachment 113513 [details] [diff] [review]
patch.

r=varga

        Attachment #113513 -
        Flags: review?(varga) → review+

    
    

    
  
suresh: hrm, so if there's no need to say seltype="multiple" in a <tree> to get
multiple selection, why then does your patch do that instead of simply removing
the multiple="true"?

    
    

    
  
jag: my patch does remove seltype from the tree.

    
    

    
  


  
New patch for the new version of CookieViewer.xul.  Would someone please check
it in.

    
  

        Attachment #117467 -
        Flags: superreview?(jaggernaut)

        Attachment #117467 -
        Flags: review?(varga)

    
  

        Attachment #117467 -
        Flags: review?(varga) → review+

    
    

    
  
Comment on attachment 117467 [details] [diff] [review]
New patch for v1.63

suresh: I must've been high or something.

sr=jag

        Attachment #117467 -
        Flags: superreview?(jaggernaut) → superreview+

    
    

    
  
fixed in trunk.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED

    
    

    
  
suresh: what was the original behavior that did not work before the fix?

I'm using Netscape 7.02, and multiple, discontiguous selections for Remove seem
to work.
QA Contact: tever → cookieqa

    
    

    
  
benc: there was no issue before this fix. It is just that there was an extra
unnecessary attribute in cookie UI. 

To verify this bug, I would make sure selection works in cookie UI (both single
and multiple selection).

    
    

    
  
VERIFIED: Mozilla 1.3f, all plats
deleting discontiguous selection works
Status: RESOLVED → VERIFIED

    
    

    
  
benc: this patch was checked in trunk. please verify this in trunk builds. thx!

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: