Closed Bug 1918490 Opened 1 year ago Closed 1 year ago

Reusable input elements support link should be outside the label

Categories

(Toolkit :: UI Widgets, defect, P3)

Product:
Toolkit
Component:
UI Widgets
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
134 Branch
Tracking Flags:
Tracking Status
firefox134 --- fixed

People

(Reporter: mstriemer, Assigned: tgiles)

References

Details

(Whiteboard: [recomp] [settings-redesign])

Attachments

(1 file)

Bug 1918490 - Move support link element outside of label element. r=#recomp-reviewers,#accessibility-frontend-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Our reusable input elements (at least moz-radio and moz-checkbox) have the support link included inside of the label element. This means if there's an accesskey that isn't included in the label it is shown after the support link (like "My feature Learn more (X)"). It also means the "Learn more" link text is read over a11y technology when focusing the input

The support link should instead be after the label, something like:

<div>
  <label><input></label>
  <a is="moz-support-link></a>
</div>
Severity: -- → S3
Assignee: nobody → tgiles
Status: NEW → ASSIGNED

The motivation for this change is to improve the screen reader user
experience when navigating through moz-checkbox and moz-radio elements.
When a screen reader encounters and focuses a moz-checkbox or
moz-radio element, only the label is announced. Previously the label
and the support-link element would be announced which is confusing since
it is not clear what will happen when activating one of these moz
elements.

Pushed by hjones@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2064995033ce Move support link element outside of label element. r=reusable-components-reviewers,accessibility-frontend-reviewers,desktop-theme-reviewers,hjones,nlapre

Backed out for causing mochitest failures @ test_moz_radio_group.html

[task 2024-11-01T13:49:54.623Z] 13:49:54     INFO - TEST-PASS | toolkit/content/tests/widgets/test_moz_radio_group.html | Radio group value matches the value of the checked button. 
[task 2024-11-01T13:49:54.624Z] 13:49:54     INFO - Buffered messages finished
[task 2024-11-01T13:49:54.625Z] 13:49:54     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_moz_radio_group.html | The expected radio button is checked. 
[task 2024-11-01T13:49:54.625Z] 13:49:54     INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:426:16
[task 2024-11-01T13:49:54.626Z] 13:49:54     INFO - verifyCheckedState@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:81:11
[task 2024-11-01T13:49:54.626Z] 13:49:54     INFO - testChangeRadioButtonChecked@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:121:25
[task 2024-11-01T13:49:54.626Z] 13:49:54     INFO - async*add_task/nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2213:34
[task 2024-11-01T13:49:54.626Z] 13:49:54     INFO - async*nextTick@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2257:11
[task 2024-11-01T13:49:54.626Z] 13:49:54     INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:922:41
[task 2024-11-01T13:49:54.627Z] 13:49:54     INFO - add_task@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2161:17
[task 2024-11-01T13:49:54.627Z] 13:49:54     INFO - add_setup@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2277:10
[task 2024-11-01T13:49:54.627Z] 13:49:54     INFO - @chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:19:14
[task 2024-11-01T13:49:54.627Z] 13:49:54     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-11-01T13:49:54.629Z] 13:49:54     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_moz_radio_group.html | The checked radio button has the correct aria-checked value. - got "false", expected "true"
[task 2024-11-01T13:49:54.629Z] 13:49:54     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:509:14
[task 2024-11-01T13:49:54.629Z] 13:49:54     INFO - verifyCheckedState@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:82:11
[task 2024-11-01T13:49:54.629Z] 13:49:54     INFO - testChangeRadioButtonChecked@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:121:25
[task 2024-11-01T13:49:54.630Z] 13:49:54     INFO - async*add_task/nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2213:34
[task 2024-11-01T13:49:54.630Z] 13:49:54     INFO - async*nextTick@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2257:11
[task 2024-11-01T13:49:54.630Z] 13:49:54     INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:922:41
[task 2024-11-01T13:49:54.630Z] 13:49:54     INFO - add_task@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2161:17
[task 2024-11-01T13:49:54.630Z] 13:49:54     INFO - add_setup@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2277:10
[task 2024-11-01T13:49:54.630Z] 13:49:54     INFO - @chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:19:14
[task 2024-11-01T13:49:54.631Z] 13:49:54     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-11-01T13:49:54.632Z] 13:49:54     INFO - TEST-UNEXPECTED-FAIL | toolkit/content/tests/widgets/test_moz_radio_group.html | The checked radio button is focusable. - got -1, expected +0
[task 2024-11-01T13:49:54.632Z] 13:49:54     INFO - SimpleTest.is@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:509:14
[task 2024-11-01T13:49:54.633Z] 13:49:54     INFO - verifyCheckedState@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:87:11
[task 2024-11-01T13:49:54.633Z] 13:49:54     INFO - testChangeRadioButtonChecked@chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:121:25
[task 2024-11-01T13:49:54.633Z] 13:49:54     INFO - async*add_task/nextTick/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2213:34
[task 2024-11-01T13:49:54.633Z] 13:49:54     INFO - async*nextTick@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2257:11
[task 2024-11-01T13:49:54.634Z] 13:49:54     INFO - setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:922:41
[task 2024-11-01T13:49:54.634Z] 13:49:54     INFO - add_task@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2161:17
[task 2024-11-01T13:49:54.634Z] 13:49:54     INFO - add_setup@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:2277:10
[task 2024-11-01T13:49:54.634Z] 13:49:54     INFO - @chrome://mochitests/content/chrome/toolkit/content/tests/widgets/test_moz_radio_group.html:19:14
[task 2024-11-01T13:49:54.635Z] 13:49:54     INFO - TEST-PASS | toolkit/content/tests/widgets/test_moz_radio_group.html | All other buttons are unchecked.

————————————————————————————
Backed out for causing bc failures @ browser_glean_sidebar.js

[task 2024-11-01T14:03:11.244Z] 14:03:11     INFO - GECKO(9139) | MEMORY STAT | vsize 11512MB | residentFast 503MB | heapAllocated 210MB
[task 2024-11-01T14:03:11.245Z] 14:03:11     INFO - TEST-OK | browser/components/sidebar/tests/browser/browser_domfullscreen_sidebar.js | took 2119ms
[task 2024-11-01T14:03:11.257Z] 14:03:11     INFO - checking window state
[task 2024-11-01T14:03:11.265Z] 14:03:11     INFO - TEST-START | browser/components/sidebar/tests/browser/browser_extensions_sidebar.js
[task 2024-11-01T14:03:11.273Z] 14:03:11     INFO - GECKO(9139) | ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-11-01T14:03:11.638Z] 14:03:11     INFO - GECKO(9139) | 1730469791637	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-11-01T14:03:12.787Z] 14:03:12     INFO - GECKO(9139) | ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-11-01T14:03:13.250Z] 14:03:13     INFO - GECKO(9139) | 1730469793249	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-11-01T14:03:14.430Z] 14:03:14     INFO - GECKO(9139) | ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-11-01T14:03:14.810Z] 14:03:14     INFO - GECKO(9139) | 1730469794805	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-11-01T14:03:15.165Z] 14:03:15     INFO - GECKO(9139) | ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-11-01T14:03:15.353Z] 14:03:15     INFO - GECKO(9139) | console.error: (new TypeError("can't access property \"QueryInterface\", aWindow.docShell is null", "resource://gre/modules/PrivateBrowsingUtils.sys.mjs", 50))
[task 2024-11-01T14:03:15.354Z] 14:03:15     INFO - GECKO(9139) | console.error: (new InvalidStateError("JSWindowActorParent.sendAsyncMessage: JSWindowActorParent cannot send at the moment", (void 0), 537))
[task 2024-11-01T14:03:15.524Z] 14:03:15     INFO - GECKO(9139) | 1730469795523	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-11-01T14:03:16.494Z] 14:03:16     INFO - GECKO(9139) | ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-11-01T14:03:16.905Z] 14:03:16     INFO - GECKO(9139) | 1730469796903	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-11-01T14:03:18.192Z] 14:03:18     INFO - GECKO(9139) | ATTENTION: default value of option mesa_glthread overridden by environment.
[task 2024-11-01T14:03:18.602Z] 14:03:18     INFO - GECKO(9139) | 1730469798597	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2024-11-01T14:03:19.757Z] 14:03:19     INFO - GECKO(9139) | MEMORY STAT | vsize 11556MB | residentFast 569MB | heapAllocated 273MB
[task 2024-11-01T14:03:19.758Z] 14:03:19     INFO - TEST-OK | browser/components/sidebar/tests/browser/browser_extensions_sidebar.js | took 8492ms
[task 2024-11-01T14:03:19.770Z] 14:03:19     INFO - checking window state
[task 2024-11-01T14:03:19.780Z] 14:03:19     INFO - TEST-START | browser/components/sidebar/tests/browser/browser_glean_sidebar.js
[task 2024-11-01T14:03:20.870Z] 14:03:20     INFO - TEST-INFO | started process screentopng
[task 2024-11-01T14:03:21.160Z] 14:03:21     INFO - TEST-INFO | screentopng: exit 0
[task 2024-11-01T14:03:21.162Z] 14:03:21     INFO - Buffered messages logged at 14:03:19
[task 2024-11-01T14:03:21.162Z] 14:03:21     INFO - Entering setup bound 
[task 2024-11-01T14:03:21.162Z] 14:03:21     INFO - Leaving setup bound 
[task 2024-11-01T14:03:21.162Z] 14:03:21     INFO - Entering test bound test_metrics_initialized
[task 2024-11-01T14:03:21.163Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | displaySettings is initialized. - "always" != null - 
[task 2024-11-01T14:03:21.163Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | positionSettings is initialized. - "left" != null - 
[task 2024-11-01T14:03:21.163Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | tabsLayout is initialized. - "horizontal" != null - 
[task 2024-11-01T14:03:21.166Z] 14:03:21     INFO - Leaving test bound test_metrics_initialized
[task 2024-11-01T14:03:21.166Z] 14:03:21     INFO - Entering test bound test_sidebar_expand
[task 2024-11-01T14:03:21.166Z] 14:03:21     INFO - Expand the sidebar.
[task 2024-11-01T14:03:21.167Z] 14:03:21     INFO - Collapse the sidebar.
[task 2024-11-01T14:03:21.167Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - 1 == 1 - 
[task 2024-11-01T14:03:21.168Z] 14:03:21     INFO - Leaving test bound test_sidebar_expand
[task 2024-11-01T14:03:21.168Z] 14:03:21     INFO - Entering test bound test_history_sidebar_toggle
[task 2024-11-01T14:03:21.168Z] 14:03:21     INFO - Load the viewHistorySidebar panel.
[task 2024-11-01T14:03:21.168Z] 14:03:21     INFO - Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://browser/content/sidebar/sidebar-history.html" line: 0}]
[task 2024-11-01T14:03:21.170Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - 1 == 1 - 
[task 2024-11-01T14:03:21.170Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was opened. - "true" == "true" - 
[task 2024-11-01T14:03:21.170Z] 14:03:21     INFO - Load the viewBookmarksSidebar panel.
[task 2024-11-01T14:03:21.170Z] 14:03:21     INFO - Buffered messages logged at 14:03:20
[task 2024-11-01T14:03:21.170Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Two events were reported. - 2 == 2 - 
[task 2024-11-01T14:03:21.170Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was closed. - "false" == "false" - 
[task 2024-11-01T14:03:21.171Z] 14:03:21     INFO - Leaving test bound test_history_sidebar_toggle
[task 2024-11-01T14:03:21.171Z] 14:03:21     INFO - Entering test bound test_synced_tabs_sidebar_toggle
[task 2024-11-01T14:03:21.172Z] 14:03:21     INFO - Load the viewTabsSidebar panel.
[task 2024-11-01T14:03:21.174Z] 14:03:21     INFO - Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://browser/content/sidebar/sidebar-syncedtabs.html" line: 0}]
[task 2024-11-01T14:03:21.174Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - 1 == 1 - 
[task 2024-11-01T14:03:21.175Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was opened. - "true" == "true" - 
[task 2024-11-01T14:03:21.176Z] 14:03:21     INFO - Unload the viewTabsSidebar panel.
[task 2024-11-01T14:03:21.176Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Two events were reported. - 2 == 2 - 
[task 2024-11-01T14:03:21.177Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was closed. - "false" == "false" - 
[task 2024-11-01T14:03:21.178Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that synced tabs aren't loaded yet. - "false" == "false" - 
[task 2024-11-01T14:03:21.179Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that synced tabs aren't loaded yet. - "false" == "false" - 
[task 2024-11-01T14:03:21.179Z] 14:03:21     INFO - Load the viewTabsSidebar panel.
[task 2024-11-01T14:03:21.180Z] 14:03:21     INFO - Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://browser/content/sidebar/sidebar-syncedtabs.html" line: 0}]
[task 2024-11-01T14:03:21.181Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - 1 == 1 - 
[task 2024-11-01T14:03:21.181Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was opened. - "true" == "true" - 
[task 2024-11-01T14:03:21.186Z] 14:03:21     INFO - Unload the viewTabsSidebar panel.
[task 2024-11-01T14:03:21.187Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Two events were reported. - 2 == 2 - 
[task 2024-11-01T14:03:21.187Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was closed. - "false" == "false" - 
[task 2024-11-01T14:03:21.188Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that synced tabs are now loaded. - "true" == "true" - 
[task 2024-11-01T14:03:21.188Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that synced tabs are now loaded. - "true" == "true" - 
[task 2024-11-01T14:03:21.189Z] 14:03:21     INFO - Leaving test bound test_synced_tabs_sidebar_toggle
[task 2024-11-01T14:03:21.189Z] 14:03:21     INFO - Entering test bound test_bookmarks_sidebar_toggle
[task 2024-11-01T14:03:21.190Z] 14:03:21     INFO - Load the viewBookmarksSidebar panel.
[task 2024-11-01T14:03:21.190Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - 1 == 1 - 
[task 2024-11-01T14:03:21.190Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was opened. - "true" == "true" - 
[task 2024-11-01T14:03:21.191Z] 14:03:21     INFO - Unload the viewBookmarksSidebar panel.
[task 2024-11-01T14:03:21.191Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Two events were reported. - 2 == 2 - 
[task 2024-11-01T14:03:21.191Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was closed. - "false" == "false" - 
[task 2024-11-01T14:03:21.191Z] 14:03:21     INFO - Leaving test bound test_bookmarks_sidebar_toggle
[task 2024-11-01T14:03:21.191Z] 14:03:21     INFO - Entering test bound test_extension_sidebar_toggle
[task 2024-11-01T14:03:21.191Z] 14:03:21     INFO - Load an extension.
[task 2024-11-01T14:03:21.191Z] 14:03:21     INFO - Extension loaded
[task 2024-11-01T14:03:21.192Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - 1 == 1 - 
[task 2024-11-01T14:03:21.193Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates the panel was opened. - "true" == true - 
[task 2024-11-01T14:03:21.193Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event has the extension's ID. - "682f8985dad74cf63a7637fbcfaa81d27897369c@temporary-addon" == true - 
[task 2024-11-01T14:03:21.194Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event has the extension's name. - "Generated extension" == true - 
[task 2024-11-01T14:03:21.195Z] 14:03:21     INFO - Unload the extension.
[task 2024-11-01T14:03:21.195Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Two events were reported. - 2 == 2 - 
[task 2024-11-01T14:03:21.196Z] 14:03:21     INFO - Leaving test bound test_extension_sidebar_toggle
[task 2024-11-01T14:03:21.196Z] 14:03:21     INFO - Entering test bound test_customize_panel_toggle
[task 2024-11-01T14:03:21.197Z] 14:03:21     INFO - Load the viewCustomizeSidebar panel.
[task 2024-11-01T14:03:21.198Z] 14:03:21     INFO - Console message: [JavaScript Warning: "Layout was forced before the page was fully loaded. If stylesheets are not yet loaded this may cause a flash of unstyled content." {file: "chrome://browser/content/sidebar/sidebar-customize.html" line: 0}]
[task 2024-11-01T14:03:21.198Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - 1 == 1 - 
[task 2024-11-01T14:03:21.199Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was opened. - "true" == "true" - 
[task 2024-11-01T14:03:21.200Z] 14:03:21     INFO - Unload the viewCustomizeSidebar panel.
[task 2024-11-01T14:03:21.200Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Two events were reported. - 2 == 2 - 
[task 2024-11-01T14:03:21.201Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Event indicates that the panel was closed. - "false" == "false" - 
[task 2024-11-01T14:03:21.202Z] 14:03:21     INFO - Leaving test bound test_customize_panel_toggle
[task 2024-11-01T14:03:21.202Z] 14:03:21     INFO - Entering test bound test_customize_icon_click
[task 2024-11-01T14:03:21.203Z] 14:03:21     INFO - Click on the gear icon.
[task 2024-11-01T14:03:21.203Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - 1 == 1 - 
[task 2024-11-01T14:03:21.204Z] 14:03:21     INFO - Leaving test bound test_customize_icon_click
[task 2024-11-01T14:03:21.204Z] 14:03:21     INFO - Entering test bound test_customize_chatbot_enabled
[task 2024-11-01T14:03:21.205Z] 14:03:21     INFO - Toggle viewGenaiChatSidebar.
[task 2024-11-01T14:03:21.205Z] 14:03:21     INFO - Buffered messages finished
[task 2024-11-01T14:03:21.209Z] 14:03:21     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Checkbox is unchecked. - true == false - 
[task 2024-11-01T14:03:21.209Z] 14:03:21     INFO - Stack trace:
[task 2024-11-01T14:03:21.209Z] 14:03:21     INFO - chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_glean_sidebar.js:testCustomizeToggle:189
[task 2024-11-01T14:03:21.209Z] 14:03:21     INFO - chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_glean_sidebar.js:test_customize_chatbot_enabled:226
[task 2024-11-01T14:03:21.210Z] 14:03:21     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2024-11-01T14:03:21.210Z] 14:03:21     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | One event was reported. - "undefined" == 1 - 
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - Stack trace:
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_glean_sidebar.js:testCustomizeToggle:195
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_glean_sidebar.js:test_customize_chatbot_enabled:226
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - chrome://mochikit/content/browser-test.js:handleTask:1147
[task 2024-11-01T14:03:21.211Z] 14:03:21     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1219
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1360
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1136
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Uncaught exception in test bound test_customize_chatbot_enabled - at chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_glean_sidebar.js:197 - TypeError: can't access property 0, events is null
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - Stack trace:
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - testCustomizeToggle@chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_glean_sidebar.js:197:5
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - async*test_customize_chatbot_enabled@chrome://mochitests/content/browser/browser/components/sidebar/tests/browser/browser_glean_sidebar.js:226:9
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - async*handleTask@chrome://mochikit/content/browser-test.js:1147:26
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1219:18
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1360:14
[task 2024-11-01T14:03:21.212Z] 14:03:21     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1136:14
[task 2024-11-01T14:03:21.213Z] 14:03:21     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1058:13
[task 2024-11-01T14:03:21.213Z] 14:03:21     INFO - Leaving test bound test_customize_chatbot_enabled
[task 2024-11-01T14:03:21.213Z] 14:03:21     INFO - Entering test bound test_customize_synced_tabs_enabled
[task 2024-11-01T14:03:21.215Z] 14:03:21     INFO - Toggle viewTabsSidebar.
[task 2024-11-01T14:03:21.215Z] 14:03:21     INFO - TEST-PASS | browser/components/sidebar/tests/browser/browser_glean_sidebar.js | Checkbox is unchecked. - false == false -
Flags: needinfo?(tgiles)
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25a8e51c3fe2 Move support link element outside of label element. r=reusable-components-reviewers,accessibility-frontend-reviewers,desktop-theme-reviewers,hjones,nlapre,sidebar-reviewers,nsharpley
Flags: needinfo?(tgiles)

Backed out for causing mochitests failures in test_moz_radio.html.

Flags: needinfo?(tgiles)
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e635c6d08284 Move support link element outside of label element. r=reusable-components-reviewers,accessibility-frontend-reviewers,desktop-theme-reviewers,hjones,nlapre,sidebar-reviewers,nsharpley
Flags: needinfo?(tgiles)

https://hg.mozilla.org/mozilla-central/rev/e635c6d08284

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox134: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: