1918638 - [Vertical tabs] Selected tab shadow is cut off on the left and right sides

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Dão Gottwald [:dao]]

Attachment: Screenshot from 2024-09-13 13-32-56.png

Seeing this on Ubuntu. Probably a regression from bug 1902083?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1902083

Comment 2

[Dão Gottwald [:dao]]

There's code dealing with a similar problem in horizontal mode here: https://searchfox.org/mozilla-central/rev/ab8043ccefe85c30ef78b97193918934d6aa93d1/browser/themes/shared/tabbrowser/tabs.css#60-65

Comment 3

[Tim Giles [:tgiles]]

Ran through mozregression on Ubuntu, and yeah it points to Bug 1902083 as being the culprit. This does appear to be a Linux only issue, as the shadow appears correctly in Windows and Mac. I'll spend some time today figuring out what the fix might look like.

Keeping needinfo open as a reminder.

Comment 4

[Sören Hentzschel]

This does appear to be a Linux only issue, as the shadow appears correctly in Windows and Mac.

For me, macOS is affected as well.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1918638 - [Vertical tabs] Stop clipping the tab-background shadow. r=#sidebar-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c36ab1469893
[Vertical tabs] Stop clipping the tab-background shadow. r=sidebar-reviewers,tabbrowser-reviewers,sclements,kcochrane,dwalker

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1918676, Bug 1918638) for causing browser chrome failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=d89CLxZ9Q9uDv8o6qz3bwg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=c36ab1469893f7cbfe41b937cc2192ad70fa9097

Log: https://treeherder.mozilla.org/logviewer?job_id=474555907&repo=autoland&lineNumber=27773
https://treeherder.mozilla.org/logviewer?job_id=474556851&repo=autoland&lineNumber=3177
https://treeherder.mozilla.org/logviewer?job_id=474562606&repo=autoland&lineNumber=9574

Backout: https://hg.mozilla.org/integration/autoland/rev/ea2112a8f5a981c48bf4d383b545f77152048964

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d7613134755
[Vertical tabs] Stop clipping the tab-background shadow. r=sidebar-reviewers,tabbrowser-reviewers,sclements,kcochrane,dwalker

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1d7613134755

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 132.0a1 (2024-09-13) on Windows 10x64. The vertically selected tab is cut off.
The issue is verified fixed with Firefox 132.0b5 on Windows 10x64, macOS 12 and Ubuntu 24.04. The vertical selected tab is correctly dispalyed.