1918664 - [wpt-sync] Sync PR 48155 - Implement RTCRtpEncodingParameters.scaleResolutionDownTo.

Status: RESOLVED FIXED

(Core :: WebRTC, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 48155 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/48155
Details from upstream follow.

Henrik Boström <[e-mail]> wrote:

Implement RTCRtpEncodingParameters.scaleResolutionDownTo.

Spec: https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-scaleresolutiondownto

Wires up scaleResolutionDownTo[1] to JS behind RuntimeEnabled flag
"RTCRtpScaleResolutionDownTo". This is implemented in third_party/webrtc
where it is called requested_resolution.

WPTs are added to test basic functionality, including getting the
resolution we expect, changing it on the fly, it being orientation
agnostic and throwing on invalid parameters.

The tests use small resolutions like 120x60 for fast ramp up even on
slow bots (sending HD tends to trigger initial frame dropping and slow
BW ramp up).

The following test coverage is NOT included yet, but will be added in
follow up CL(s):

• Simulcast tests: to be written in a separate CL for reviewability.
• scaleTo maintaining aspect ratio: blocked on a WebRTC fix.

[1] https://github.com/w3c/webrtc-extensions/pull/221

Bug: chromium:363544347
Change-Id: If930ffd686d073d2eb239763e9ea9c1390fbcef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5828607
Reviewed-by: Dominik Röttsches \<[e-mail]>
Commit-Queue: Henrik Boström \<[e-mail]>
Reviewed-by: Harald Alvestrand \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1355122}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=edd97b9c9849323a797a77c5029f47a6be731fea

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

FAIL : 2
TIMEOUT: 2
NOTRUN : 4

Chrome

PASS : 1
FAIL : 1
TIMEOUT: 2
NOTRUN : 4

Safari

FAIL : 2
TIMEOUT: 2
NOTRUN : 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webrtc-extensions/RTCRtpEncodingParameters-scaleResolutionDownTo.https.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • addTransceiver: Specifying scaling on some but not all encodings throws: FAIL (Chrome: FAIL, Safari: FAIL)
  • setParameters: Specifying scaling on some but not all encodings throws: FAIL (Chrome: PASS, Safari: FAIL)
  • addTransceiver: scaleResolutionDownBy is ignored when scaleResolutionDownTo is specified: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • setParameters: scaleResolutionDownBy is ignored when scaleResolutionDownTo is specified: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
  • addTransceiver: scaleResolutionDownTo with half resolution: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
  • setParameters: Modify scaleResolutionDownTo while sending: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)
  • scaleResolutionDownTo is orientation agnostic: NOTRUN (Chrome: NOTRUN, Safari: NOTRUN)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2853f7cfdf43
[wpt PR 48155] - Implement RTCRtpEncodingParameters.scaleResolutionDownTo., a=testonly
https://hg.mozilla.org/integration/autoland/rev/dfefaba12ef6
[wpt PR 48155] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2853f7cfdf43
https://hg.mozilla.org/mozilla-central/rev/dfefaba12ef6