1918707 - browser_quicksuggest_fakespot fails when using NUMBER() in Fluent strings

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect)

Description

[Francesco Lodolo [:flod]]

In bug 1918411 I tried to use NUMBER() in the Fluent variant selector. That shouldn't have consequences to tests, but ended up creating failures

# Show the exact number of reviews.
firefox-suggest-fakespot-rating-and-total-reviews =
  { NUMBER($totalReviews) ->
     [one] { $rating } · ({ $totalReviews } review)
    *[other] { $rating } · ({ $totalReviews } reviews)
  }
# Show an approximate number of reviews (e.g. 100,000+ reviews).
firefox-suggest-fakespot-rating-and-total-reviews-overflow =
  { NUMBER($totalReviews) ->
     [one] { $rating } · ({ $totalReviews }+ review)
    *[other] { $rating } · ({ $totalReviews }+ reviews)
  }

Test failure

Unexpected Results
------------------
browser/components/urlbar/tests/quicksuggest/browser/browser_quicksuggest_fakespot.js
  FAIL "5 · (1 reviews)" == "5 · (1 review)" -

I assume the variable is not actually passed as a number, so we always use the default variant.

Comment 1

[Francesco Lodolo [:flod]]

So far I haven't been able to spot an obvious issue, the number seems to be passed as a number (at least in the payload).

Comment 2

[Francesco Lodolo [:flod]]

Apparently our fluent-rs implementation doesn't support NUMBER(), luckily you had a test for 1.

Closing this as INVALID, since it's not a bug in the test.