1918856 - Do serialization of computed `border-spacing` in stylo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Martin Robinson (email:[e-mail])]

border-spacing serializes in a special way compared to other Size2D types. Both values should be serialized even if they are equal. Moving this to stylo allows Servo to share this special serialization code.

Comment 1

[Martin Robinson (email:[e-mail])]

Attachment: Bug 1918856 - Do serialization of computed `border-spacing` in stylo r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22da217ea4e5
Do serialization of computed `border-spacing` in stylo r=emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48863 for changes under testing/web-platform/tests

Comment 4

[Atila Butkovits]

Backed out for causing failures at test_transitions_per_property.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/f7f7072e7d5f71ea2b23f74af9c2f8d6f4e9e83f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=cFlGKp_zRtm_Q8U8yL9Ecw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=22da217ea4e58999779581038f3368dda5af20cf

Failure log: https://treeherder.mozilla.org/logviewer?job_id=480309798&repo=autoland&lineNumber=6930

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 6

[Martin Robinson (email:[e-mail])]

Attachment: Bug 1918856 - Do serialization of computed `border-spacing` in stylo r=emilio

Reland of D222204: This fixes an issues in
test_transitions_per_property.html where border-spacing was assumed
to serialize to 0px 0px. It follows the pattern used by other
properties that do not serialize this way.

Comment 7

[Martin Robinson (email:[e-mail])]

I've uploaded a new version of this change that I believe addresses the issues in the mochitests.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c952710a4cd
Do serialization of computed `border-spacing` in stylo r=emilio

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3c952710a4cd

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot