1919185 - Investigate links and radio buttons that are failing Tier 2 a11y_checks for Customize Sidebar

Status: RESOLVED FIXED

(Firefox :: Sidebar, task, P1)

Description

[Jonathan Sudiaman [:jsudiaman]]

A couple of interactions in the customize panel are causing Node is not focusable via the accessibility API errors:

• Clicking on an extension link.
• Clicking on a <moz-radio> element.

We have been dodging this in browser_customize_sidebar.js by running the tests in a new window, but now this is causing failures in browser_glean_sidebar.js (which does not run in a new window).

We should investigate why these checks are failing, rather than creating unnecessary windows.

Comment 1

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1919185: Temporary disable a11y_checks for browser_glean_sidebar.js. r?#sidebar-reviewers

Filed Bug 1919185 to address the failing tests. Skip them for the time being.

Comment 2

[Phabricator Automation]

Comment on attachment 9425300 [details]
Bug 1919185: Temporary disable a11y_checks for browser_glean_sidebar.js. r?#sidebar-reviewers

Revision D222474 was moved to bug 1919108. Setting attachment 9425300 [details] to obsolete.

Comment 3

[Sarah Clements [:sclements]]

Jonathan, did you happen to take a look at the docs? There's some useful guidance to get this passsing ie, “After that, check the element is, in fact, visible and accessible when the test is clicking it. For example, when dealing with a pop-up panel, sometimes we may need to wait for the panel to be shown before clicking a button inside it.”

Comment 4

[Jonathan Sudiaman [:jsudiaman]]

Attachment: Bug 1919185 - Fix links and radio buttons that are failing Tier 2 a11y_checks for Customize Sidebar r?#sidebar-reviewers

For extension links, AccessibilityUtils was checking the <a> element, rather than its container. Moving tabIndex over to the inner "link" seemed to remedy this.
For radio inputs, we should not be checking tabIndex as <moz-radio-group> only allows focus on the active radio option (by design).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d38ca653be7
Fix links and radio buttons that are failing Tier 2 a11y_checks for Customize Sidebar r=sidebar-reviewers,accessibility-frontend-reviewers,Gijs,Jamie

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2d38ca653be7