1919224 - No toolbar top divider after microsurvey options closed in home screen

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: NoDividerAfterClosingHomeSurveyOptions.mp4

Steps to reproduce

1. Have the toolbar set at bottom
2. Get a microsurvey
3. Tap "Continue" to interact with the prompt options
4. Close the survey - by tapping submit or clicking on the "X" button

Expected behavior

The small divider line at the top of the toolbar is shown again after previously being hidden when the microsurvey was showing.

Actual behavior

The small divider line at the top of the toolbar is not shown again until navigating between screens to reinitialize the toolbar.

Any additional information?

This bug does not affect the microsurvey prompt - which if closed will result in the divider showing
Only the microsurvey options bottom sheet dialog - which if closed witll not automatically result in the divider showing

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1919224 - Restore the toolbar background after the microsurvey options dialog is dismissed r=#android-reviewers

We were already showing the divider when the survey prompt is closed.
Now using isMicrosurveyPromptDismissed.value to know when either of the survey prompt
or the survey options dialog was closed to show the default toolbar divider.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4884c55c55e8
Restore the toolbar background after the microsurvey options dialog is dismissed r=android-reviewers,twhite

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/4884c55c55e8

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Petru-Mugurel Lingurar [:petru]]

This is a very minute detail which comes after important navbar changes.
Confirmed with Tom (who works on the microsurveys) that it's okay to let this ride the trains.