Open Bug 1919263 Opened 5 months ago Updated 25 days ago

nbcsports.com - videos and photos are no displayed

Categories

(Web Compatibility :: Site Reports, defect, P2)

Firefox 130
Desktop
Windows 11

Tracking

(Webcompat Priority:P2, firefox130 affected, firefox132 affected)

Webcompat Priority P2
Tracking Status
firefox130 --- affected
firefox132 --- affected

People

(Reporter: railioaie, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: webcompat:needs-contact, webcompat:site-report, Whiteboard: [webcompat-source:product][webcompat:sightline])

User Story

platform:windows,mac,linux,android
impact:content-missing
configuration:general
affects:all
branch:release
diagnosis-team:DOM

Attachments

(1 file)

Environment:
Operating system: Windows 11
Firefox version: Firefox 130.0 (release)

Preconditions:

  • Clean profile

Steps to reproduce:

  1. Navigate to: https://www.nbcsports.com/nfl/profootballtalk/rumor-mill
  2. Observe the page

Expected Behavior:
The videos and photos are displayed correctly

Actual Behavior:
The videos and photos are not displayed

Notes:

  • Reproducible on the latest Firefox Release and Nightly
  • Reproducible regardless of the ETP setting
  • Works as expected using Chrome

Created from webcompat-user-report:483a904e-8730-40e9-9522-e8f7fdb23e56

Severity: -- → S2
User Story: (updated)
Priority: P3 → P2

Occasionally on reload videos will be displayed in Firefox. This may be similar to another issue where the site made assumptions that images would be loaded and have widths available when a script runs.

The videos don't show up in Safari either.

I see the following exception during video player init:

Uncaught (in promise) TypeError: t.getCurrentUser is not a function
    get vcid2 https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    setAdvertising https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    n https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    init https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    connectedCallback https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    promise callback*connectedCallback https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    Q https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    700 https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    l https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    <anonymous> https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
    <anonymous> https://nbcsports.brightspotcdn.com/resource/00000187-de45-d718-ada7-fe4596550000/styles/default/All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2
10 All.min.e4ec4bc3edff2942967114430a5fe136.gz.js:2:56911

I think this might have to do with script load order. i.e. I think Chrome might be loading mpacket earlier and and avoiding the t.getCurrentUser problem.

User Story: (updated)
Flags: needinfo?(smaug)

Jeff and I can't reproduce this anymore.

railioaie, can you still repro it in 134?

Flags: needinfo?(smaug) → needinfo?(railioaie)

Hello. It's still reproducible for me. Thanks!

Flags: needinfo?(railioaie)
Attached image Screenshot_121.png

railioaie, does the video show up after a few seconds? For me, especially the first load, the image takes a bout 5-6 seconds to show up. Can you confirm this?

If the video is not showing up at all, can you use https://profiler.firefox.com/ to collect a profile, maybe I can use it to see the loading differences.

Flags: needinfo?(railioaie)

Hello. Please see if this can help you: https://share.firefox.dev/48N99UG

Flags: needinfo?(railioaie)

That's really helpful, thanks!

I turned out I had to disable my ads blocker because the site creates a noop for getCurrentUser when ads blocker is enabled, so it actually works that way!

So the site expects a javascript file called mparticle.js file to be loaded first so that the getCurrentUser method can be set. And this is how the file is injected

    var f = document.createElement('script');
    f.type = 'text/javascript';
    f.async = true;
    f.src = (
      'https:' == document.location.protocol ? 'https://jssdkcdns' : 'http://jssdkcdn'
    ) + '.mparticle.com/js/v2/' + e + '/mparticle.js' + l + '&' + m.join('&');
    var p = document.getElementsByTagName('script') [0];
    p.parentNode.insertBefore(f, p)

This is an async javascript, so whenever it runs is not guaranteed. This is similar to bug 1902494.

I think this is a site bug.

Whiteboard: [webcompat-source:product] → [webcompat-source:product][webcompat:sightline]
Webcompat Priority: --- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: