191927 - incorrect build order for statically linked TestGtkEmbed

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Brian Ryner (not reading)]

In a static build, we link all of the components into the library created in
embedding/browser/gtk/src.  However, not all of the components we want to link
in have been built at the time this directory is traversed.  Because of the way
the Makefile in that directory works, it won't cause a build failure, it will
just silently skip linking in some of the components.

Comment 1

[hacker formerly known as [e-mail]]

Looking at this closer, I'm not even sure if this is an issue. 
embedding/browser/gtk/src/Makefile.in creates a static library.  So in a static
build, those extra components that we depend upon never show up in the link (ar
cr) line at all anyway.  

Ok, I see the real problem.  The component names are used to create the
entrypoints in EmbedComponents.cpp.  The initial list of component names are
grabbed from embedding/config/basebrowser-unix but only the names that actually
show up in the generated FINAL_LINK_COMPS list are actually used by
EmbedComponents.cpp.  And since someone decided to add various add-on bits like
psm & wallet to basebrowser-unix, gtkembedmoz misses out on them.

Comment 2

[Brian Ryner (not reading)]

Attachment: patch

Comment 3

[hacker formerly known as [e-mail]]

Comment on attachment 113542 [details] [diff] [review]
patch

r=cls

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 113542 [details] [diff] [review]
patch

a=asa.

Comment 5

[Brian Ryner (not reading)]

checked in.