Closed Bug 1919356 Opened 2 years ago Closed 1 year ago

[css-view-transitions] Skip transition on viewport resizes.

Categories

(Core :: CSS Parsing and Computation, task, P3)

task

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: emilio, Assigned: boris)

References

(Blocks 1 open bug)

Details

(Whiteboard: [viewtransitions:m1], [wptsync upstream])

Attachments

(1 external file)

We need to track viewport resizes and abort the transition when that happens.

Whiteboard: [viewtransitions:m1]

Thinking about this bug.
Per spec, we need to compare the current containing block size to the initial one, mInitialSnapshotContainingBlockSize, in
https://searchfox.org/mozilla-central/rev/6fc1a107c44e011a585614cbbe8826f9e01ec802/dom/view-transitions/ViewTransition.cpp#667.

The related WPT is https://searchfox.org/mozilla-central/rev/6fc1a107c44e011a585614cbbe8826f9e01ec802/testing/web-platform/tests/css/css-view-transitions/window-resize-aborts-transition.html.

And looks like this is the root cause of Bug 1945023 because we may timeout when running the Test Verification on this test.

Blocks: 1945023
Assignee: nobody → boris.chiou
Status: NEW → ASSIGNED

Also, we have to make sure we resolve or reject the finished promise in
SkipTransition() because mPhase may not be Done in
CallUpdateCallback().

Besides, we have to update tests to use empty string when opening a popup
window to avoid replacing its original document with another blank document.

This replacement may cause timeout because we destroy the original document
(which runs view tranistions) after some animation frames, and so we
keep waiting the new animation frames or any promises of the view
transitions.

Pushed by bchiou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13e5b704f147 Skip view transitions when we resize the viewport size. r=view-transitions-reviewers,emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/50787 for changes under testing/web-platform/tests
Whiteboard: [viewtransitions:m1] → [viewtransitions:m1], [wptsync upstream]
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
Upstream PR merged by moz-wptsync-bot
Duplicate of this bug: 1945023
Duplicate of this bug: 1896075
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: