1919473 - The CSC field is autofilled and the autocomplete dropdown is displayed for it as well

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P1)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: 2024-09-18_12h39_19.mp4

Found in

• 132.0a1 (2024-09-18)

Affected versions

• 132.0a1

Tested platforms

• Affected platforms: Windows 10, macOS 12, Ubuntu 20

Preconditions

• browser.search.region US

Steps to reproduce

1. Go to https://luke-chang.github.io/autofill-demo/basic_cc.html
2. Fill in all the fields and click submit
3. Save the CC via CC capture doorhanger
4. Click on the CSC field and select the entry from the autocomplete dropdown

Expected result

1. The CC autocomplete dropdown should not be displayed for the CSC field and it should also not be autofilled if the autofill is triggered from another field.

Actual result

1. The CC autocomplete dropdown is displayed for the CSC field and it is also autofilled.

Regression range

• Regressed by bug 1916945.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1916945

:dimi, since you are the author of the regressor, bug 1916945, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1919473 - Ensure we do not save or autofill csc r=#credential-management-reviewers

Bug 1916945 incorrectly assumes that we don't save unknown fields.
This patch addresses the issue by intentionally filtering out the cc-csc field
when saving or autofilling.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ac2c22e263
Ensure we do not save or autofill csc r=credential-management-reviewers,issammani

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a9ac2c22e263

Comment 5

[Alin Ilea, Desktop Test Engineering]

Verified - Fixed in latest Nightly 132.0a1 (build id: 20240918211346). The CSC field is no longer autofilled.