191965 - Hang when trying to "Save page As..."

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[R.K.Aa.]

current trunk CVS, Linux

I rarely save pages so i don't know if this is new. But reproduced 4 times in a
row now.

To reproduce: 

-Go to http://www.vg.no
-Click any link called "Les hele saken" and let the following page load
-Now click "File" -> "Save Page As..."
 Filepicer now appears with suggested filename - accept

Result:
After this the file manager may or may not appear, but Mozilla will regardless
freeze only seconds later. The page seems to be saved however.
But i have to kill mozilla with -9 ("killall mozilla-bin" alone doesn't work)

There must be something special about stories at that site, I can save some
other sites OK.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Are you saving as "web page, complete", or "web page, HTML only"?

Are you using the download manager, or the progress dialog?

When did you pull your build from CVS?

("Does renaming XUL.mfasl help?"  ;))

Comment 2

[Andrew Schultz]

Attachment: stacktrace

mozilla.org binary build crashed.  Debug build seemed to hang, but it was
actually the signal handler which caught the crash and was waiting for me to
attach gdb (except there was no indication of that).

Comment 3

[R.K.Aa.]

>Are you saving as "web page, complete", or "web page, HTML only"?
web page, complete

>Are you using the download manager, or the progress dialog?
download manager (i gave up getting rid of it)

>When did you pull your build from CVS?
no new checkins since i built

>("Does renaming XUL.mfasl help?"  ;))
"You wish" ;)

Comment 4

[Boris Zbarsky [:bzbarsky]]

jkeiser?  The last part of that before we get into strings looks like HTMLValue
code....

Comment 5

[Andrew Schultz]

Attachment: problems seen by valgrind

Comment 6

[Andrew Schultz]

for this URL:
http://vg.transact.no/Item.asp?GroupID=131&Group=Politikk%20-%20Internasjonal&ThreadID=322160&Thread=Nå%20avviser%20Saddam%20USA-bevisene,latterlig%20syns%20jeg!
the call to encoder.EncodeSegmentCount(spec,mQuery,esc_Query,encQuery) returns 0
http://lxr.mozilla.org/mozilla/source/netwerk/base/src/nsStandardURL.cpp#494

which is obviously wrong.  |buf| is allocated too small and big problems follow.
 The difference between that and the other URLs (which are handled properly)
seems to be the "å".

==> Networking

Comment 7

[Andrew Schultz]

networking for real

Comment 8

[Boris Zbarsky [:bzbarsky]]

To darin, ccing nhotta....

Comment 9

[Darin Fisher]

should be easy enough to fix... targeting 1.3

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

These seem relevant:

###!!! ASSERTION: not a UTF8 string: 'Error', file
../../dist/include/string/nsReadableUtils.h, line 447
Break: at file ../../dist/include/string/nsReadableUtils.h, line 447
###!!! ASSERTION: Input wasn't UTF8 or incorrect length was calculated: 'Error',
file /builds/trunk/mozilla/string/obsolete/nsString2.cpp, line 1401
Break: at file /builds/trunk/mozilla/string/obsolete/nsString2.cpp, line 1401
###!!! ASSERTION: not a UTF8 string: 'Error', file
../../dist/include/string/nsReadableUtils.h, line 447
Break: at file ../../dist/include/string/nsReadableUtils.h, line 447
###!!! ASSERTION: Input wasn't UTF8 or incorrect length was calculated: 'Error',
file /builds/trunk/mozilla/string/obsolete/nsString2.cpp, line 1401
Break: at file /builds/trunk/mozilla/string/obsolete/nsString2.cpp, line 1401

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This fixes the crash (the first change may not even be needed for this crash). 
Different error handling in the URL code might be nice, though.

Comment 12

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 113688 [details] [diff] [review]
patch

ugh.  ;)

Comment 13

[Adam Lock]

Comment on attachment 113688 [details] [diff] [review]
patch

Nice catch, r=adamlock

I think we have other bugs about saving to international filenames. I'll see if
they're still open.

Comment 14

[Darin Fisher]

-> dbaron :)

Comment 15

[Christian :Biesinger (don't email me, ping me on IRC)]

bugs like this one make me wonder why we even still have AssignWithConversion,
is there a special reason?

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Because people get mad when we make too many string API changes, and we don't
really have the "right solution" for conversion ready yet...

Comment 17

[Asa Dotzler [:asa]]

Comment on attachment 113688 [details] [diff] [review]
patch

Let's hold off until final.

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 113688 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.3final.

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-02-11 12:28 PST.