Closed
Bug 191967
Opened 22 years ago
Closed 22 years ago
[FIXr]input image with border=1 causes bad resizing
Categories
(Core :: Layout: Form Controls, defect, P2)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla1.3final
People
(Reporter: bugz-moz, Assigned: bzbarsky)
Details
Attachments
(3 files)
3.56 KB,
image/gif
|
Details | |
1.87 KB,
text/html
|
Details | |
774 bytes,
patch
|
dbaron
:
review+
dbaron
:
superreview+
asa
:
approval1.3b-
asa
:
approval1.3+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030204 Phoenix/0.5 Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030204 Phoenix/0.5 The border atrribute in <input type=image ... border=1> improperly shrinks the image by one pixel in each direction. In my test case, the correct width= and height= are specified, but the browser atttemps to squeeze the image _and_ border into that space. So the image appears broken up a bit by the bad resizing. Reproducible: Always Steps to Reproduce: 1. Create a form with an image input control <input type=image src=...>. 2. Add the correct width and height attributes and border=1. 3. Compare to the equivilant <img src=...>. Actual Results: The input image in badly resized, differing from the <img...> equivilent. Expected Results: The input image should be identical to the <img...> in size, or should ignore the border attribute. Exactly how Mozilla should treat <input type=image ... border=1> is debatable, but it should not resize the image. Possible renderings include: 1. A one pixel border in the default border color. 2. A one pixel border in the link color. (Netscape 4.7 does this.) 3. Ignore the attribute and require CSS. (Opera 6.50 and IE6 ignore border=1, but you will not find CSS much help for this tag in those browsers.) It should probably render very like an <img...> within an <a href...>...</a>, and have the same CSS available. Support for input image attributes is generally bad in other browsers, although "align" does usually work. Netscape <=4.7 was unusual in setting a colored two-pixel border by default, even with no border attribute. I originally posted this info in Bug 171598, but the fix for that transparency bug did not fix this bug.
Assignee | ||
Comment 3•22 years ago
|
||
This is due to our box-sizing quirk on inputs... Should this quirk really apply to <input type="image">? (it has all along, of course). In standards mode we treat the border as being in addition to the specified width.
Status: UNCONFIRMED → NEW
Ever confirmed: true
The box-sizing quirk probably shouldn't apply to inputs with type=image.
Assignee | ||
Comment 5•22 years ago
|
||
Assignee | ||
Comment 6•22 years ago
|
||
to me
Assignee: form → bzbarsky
OS: Windows 98 → All
Priority: -- → P2
Hardware: PC → All
Summary: input image with border=1 causes bad resizing → [FIX]input image with border=1 causes bad resizing
Target Milestone: --- → mozilla1.3final
Assignee | ||
Updated•22 years ago
|
Attachment #113599 -
Flags: superreview?(dbaron)
Attachment #113599 -
Flags: review?(dbaron)
Attachment #113599 -
Flags: superreview+
Attachment #113599 -
Flags: review+
Assignee | ||
Comment 7•22 years ago
|
||
Comment on attachment 113599 [details] [diff] [review] something like this, perhaps? Could this please be approved for 1.3b? It makes us a little less quirky in the case of <input type="image">....
Attachment #113599 -
Flags: superreview?(dbaron)
Attachment #113599 -
Flags: review?(dbaron)
Attachment #113599 -
Flags: approval1.3b?
Comment 8•22 years ago
|
||
Comment on attachment 113599 [details] [diff] [review] something like this, perhaps? We're trying to get 1.3beta out the door. This is going to have to wait.
Attachment #113599 -
Flags: approval1.3b? → approval1.3b-
Assignee | ||
Updated•22 years ago
|
Summary: [FIX]input image with border=1 causes bad resizing → [FIXr]input image with border=1 causes bad resizing
Assignee | ||
Comment 9•22 years ago
|
||
Comment on attachment 113599 [details] [diff] [review] something like this, perhaps? Are drivers ok with taking this de-quirk for 1.3?
Attachment #113599 -
Flags: approval1.3?
Comment 10•22 years ago
|
||
Comment on attachment 113599 [details] [diff] [review] something like this, perhaps? a=asa (on behalf of drivers) for checkin to 1.3 final.
Attachment #113599 -
Flags: approval1.3? → approval1.3+
Assignee | ||
Comment 11•22 years ago
|
||
fixed for 1.3final.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•