1919716 - 0.18% installer size (OSX) regression on Thu September 12 2024

Status: RESOLVED WONTFIX

(Testing :: Performance, defect, P2)

Description

[Treeherder Bug Filer]

Perfherder has detected a build_metrics performance regression from push 7bf94a5926970a17e9c00b4d22726659e417b318. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
0.18%	installer size	osx-cross		98,016,801.75 -> 98,194,920.58

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

You can run these tests on try with ./mach try perf --alert 2077

For more information on performance sheriffing please see our FAQ.

Comment 1

[Alex Finder]

Hi Dana! I redirected the needinfo to you, the triage owner, since the author of the regressing bug 1915849, bbeurdouche, has blocked incoming needinfos. Could you please reach out to the author and agree on the next steps (fix/backout/other) ? Thanks!

Comment 2

[John Schanck [:jschanck]]

This should have been at least partially mitigated by https://hg.mozilla.org/mozilla-central/rev/689431d0027c. However, we did expect some size regression here as there is a significant amount of new (security critical) code.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1915849

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1915849

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:afinder, could you have a look please?

For more information, please visit BugBot documentation.

Comment 6

[Alex Finder]

(In reply to John Schanck [:jschanck] from comment #2)

This should have been at least partially mitigated by https://hg.mozilla.org/mozilla-central/rev/689431d0027c. However, we did expect some size regression here as there is a significant amount of new (security critical) code.

Hi John! Following up on this. Should we close this defect as wontfix ? Thanks!

Comment 7

[John Schanck [:jschanck]]

Yes, as I suggested in Comment 2, this was resolved by the followup patch https://treeherder.mozilla.org/perfherder/graphs?highlightAlerts=0&highlightChangelogData=0&highlightCommonAlerts=0&highlightedRevisions=7bf94a5926970a17e9&highlightedRevisions=689431d0027c&replicates=0&series=autoland,2614662,1,2&timerange=5184000&zoom=1726123545567,1726580056440,97425636.67502369,98820512.3612982.