1919742 - [GB][currys.co.uk] The address fields are autofilled separately

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Alin Ilea, Desktop Test Engineering]

Attachment: www.currys.co.uk.mp4

Found in

• Nightly 132.0a1

Affected versions

• N/A

Tested platforms

• Affected platforms: Windows 10, macOS 11

Preconditions

• install en-GB Firefox build
• use GB VPN
• set browser.search.region = GB
• extensions.formautofill.addresses.experiments.enabled = true
• extensions.formautofill.addresses.supportedCountries = GB

Steps to reproduce

1. Go to https://www.currys.co.uk/
2. Add an item to cart and proceed to checkout.
3. Click on the first name field and select an entry from the autocomplete dropdown.
4. Click on the address 1 or town/city field and select an entry from the autocomplete dropdown.

Expected result

• All the fields should be autofilled accordingly.

Actual result

• The fields are autofilled separately. The Name, phone number, postal code and company fields seems to be grouped separately from the Address 1, Address 2 and town/city fields.

Regression range

• N/A

Additional notes

• Not reproducible in Chrome, all fields are autofilled accordingly there.
• The Street address is autofilled in the Company field (reproducible in Chrome as well).
• about:autofill in comment 1.
• Fathom Fox

Comment 1

[Alin Ilea, Desktop Test Engineering]

Attachment: 2024-09-18_17h01_27.png

about:autofill

Comment 2

[Neil Deakin]

The company/organization field is being misidentified as an address-line1 field, causing the remaining fields to get put into a separate section.

Comment 3

[Neil Deakin]

Attachment: Bug 1919742, improve how duplicate form fields types are handled to avoid unncessary section splits, r=#credential-management-reviewers

The change is to move a field that is of the same field type as a previous field into a seprate section,
as before, but when the next fields are not duplicates, put them in the original section instead,
assuming that they do not specify a section. However, when two or more duplicate fields exist, continue
to place them in a new section as before. This change better handles some cases when an error exists
in the page, or when there is a single field that is meant to be hidden.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be0ef088a5fe
improve how duplicate form fields types are handled to avoid unncessary section splits, r=credential-management-reviewers,dimi

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/be0ef088a5fe

Comment 6

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Verified as fixed using Firefox Nightly 140.0a1 (2025-04-28), on macOS 14. The address fields are no longer autofilled separately and the Street address is also no longer autofilled in the Company field. Autofill is working as expected.