Closed
Bug 1919778
Opened 1 year ago
Closed 1 year ago
Remove global constructors from dom/media/ipc/RemoteDecoderManagerChild.cpp
Categories
(Firefox Build System :: General, task)
Firefox Build System
General
Tracking
(firefox132 fixed)
RESOLVED
FIXED
132 Branch
| Tracking | Status | |
|---|---|---|
| firefox132 | --- | fixed |
People
(Reporter: sergesanspaille, Assigned: sergesanspaille)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(1 file)
No description provided.
| Assignee | ||
Comment 1•1 year ago
|
||
This makes sure we don't have associated global constructor.
It requires flagging some default constructor as constexpr, including
one from a union which we circumvent by adding a default field for the
uninitialized state of the union.
Updated•1 year ago
|
Attachment #9425882 -
Attachment description: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT → WIP: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT
Updated•1 year ago
|
Attachment #9425882 -
Attachment description: WIP: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT → Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT
Updated•1 year ago
|
Attachment #9425882 -
Attachment description: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT → WIP: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT
Updated•1 year ago
|
Attachment #9425882 -
Attachment description: WIP: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT → Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT
Pushed by sguelton@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7db42ac7850b
Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT r=media-playback-reviewers,padenot
Comment 3•1 year ago
|
||
Backed out for causing Hazard bustages at RegExpAPI.cpp.
Backout link: https://hg.mozilla.org/integration/autoland/rev/5df77294091a8ae2c2d57fefcd5ee1fbe24ccc37
Failure log: https://treeherder.mozilla.org/logviewer?job_id=475605496&repo=autoland&lineNumber=29351
Updated•1 year ago
|
Attachment #9425882 -
Attachment description: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT → WIP: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT
Updated•1 year ago
|
Attachment #9425882 -
Attachment description: WIP: Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT → Bug 1919778 - Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT
Pushed by sguelton@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f9981053145
Flag EnumeratedArray variable from dom/media/ipc/RemoteDecoderManagerChild.cpp as MOZ_CONSTINIT r=media-playback-reviewers,padenot
Comment 5•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox132:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•