1919891 - Add always to the app links redirect prompt

Status: RESOLVED FIXED

(Firefox for Android :: App Links, enhancement)

Description

[Roger Yang [:royang]]

This issue is created from the comments of https://bugzilla.mozilla.org/show_bug.cgi?id=1826507

Currently the app links prompt dialog only have two options ("Cancel" and "Open"). We should add another option (or a tickbox) to allow user to modify their preference without going to the settings.

If the user ticks "always" and then selects "Cancel", we will cancel the redirect and also set user preference to "Never".
If the user ticks "always" and then selects "Open", we will redirect to the external app and also set user preference to "Always".

Comment 1

[Roger Yang [:royang]]

:mverdi, what do you think about this suggestion? Thanks

Comment 2

[Andrei Popa]

Hello,

Working on this ticket I was thinking if we should use “always” on the prompt dialog.
Given the fact that on Open links in apps screen we have 3 choices(“Always”, “Ask before opening” and “Never”), the user might be confused to see “always” on the prompt also. Both “always” / “Always” choices seem similar but can lead to different app behavior.
If the user ticks “always” this would mean that “Always” option or “Never” option would be enabled in the settings, depending on user’s choice.

I was thinking that maybe we can use “Remember my decision” or “Don’t ask again” instead of “always”.

:royang, please let me know if you have any thoughts about this suggestion.

Thank you!

Comment 3

[Cathy Lu [:calu]]

Attachment: Example from Arc Search

An example from Arc Search how their dialog presents this option.

Comment 4

[Andrei Popa]

Attachment: Bug 1919891 - added a checkbox to the redirect dialog layout and actions based on user clicks on the dialog

Comment 5

[twhite]

(In reply to Andrei Popa from comment #2)
Agree that this currently may be a little confusing for users, I think a small change that would help is updating the text to include some context to the checkbox label e.g. "Always open link in apps" - being consistent with the verbage already used in settings.

If the user ticks “always” this would mean that “Always” option or “Never” option would be enabled in the settings, depending on user’s choice.


Is this suggesting the "Cancel" option would set the "Never" setting? I'm assmuing pressing "Cancel" should not update any settings and only close the Dialog?

Comment 6

[Andrei Popa]

:twhite the current behavior is:

When user taps Cancel, the dialog will be closed and will not be shown for 1 hour and the settings will not be changed/updated.
If the user taps Open, it will open in a 3rd party app.



With the changes in the patch:

When checkbox is not ticked, we have the same behavior as mentioned above.
When the checkbox is ticked and (as per Roger’s first comment on this bug):
- user taps Open, the settings will be updated to Always.
- user taps Cancel, the settings will be updated to Never.

Do we want to change this behavior?

Comment 7

[twhite]

When the checkbox is ticked and (as per Roger’s first comment on this bug):

• user taps Open, the settings will be updated to Always.
• user taps Cancel, the settings will be updated to Never.

Thanks for clarifying - overriding the "Cancel" button with the "Never" behaviour sounds pretty confusing to me, I strongly suspect it would be to users to - perhaps we should have an explicit "Never" option - perhaps even remove the"Cancel" option altogether if "Never" is more important?

Comment 8

[twhite]

When user taps Cancel, the dialog will be closed and will not be shown for 1 hour and the settings will not be changed/updated.

Out of scope for this bug but I also find the 1 hour delay behaviour to be unexpected, a user may have pressed cancel accidentally or pressed the wrong link. It's not explicit to the users this is going to be a side effect of pressing "Cancel".

Roger, do you have any context for this?

Comment 9

[Roger Yang [:royang]]

(In reply to twhite from comment #8)

Out of scope for this bug but I also find the 1 hour delay behaviour to be unexpected, a user may have pressed cancel accidentally or pressed the wrong link. It's not explicit to the users this is going to be a side effect of pressing "Cancel".

This is for websites that frequently tries to redirect us to their app. There were complaints that a site keep triggering the prompt every minute or so. So we added this timeout. The 1 hour timeout only apply to the current tab. If they open a new tab it will prompt again.

Comment 10

[Andrei Popa]

After discussing with Tom regarding the next steps for this work item, the conclusion was as follows:

1. We will implement the checkbox and when the user taps Open, depending if the checkbox is ticked or not the setting will/will not be changed to Always.
2. For the Cancel button the only behaviour is to cancel the prompt(no changes to settings).
3. The option that changes the setting to “Never” will be implemented in some follow up tasks.

Comment 11

[Andrei Popa]

Attachment: Bug 1919891 - Part 2: Removed redundant parameter calls with default values

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a29905f63c7
added a checkbox to the redirect dialog layout and actions based on user clicks on the dialog r=android-reviewers,cwzilla,twhite,mavduevskiy
https://hg.mozilla.org/integration/autoland/rev/0f63c743885d
Part 2: Removed redundant parameter calls with default values r=android-reviewers,twhite

Comment 13

[amarc]

https://hg.mozilla.org/mozilla-central/rev/4a29905f63c7
https://hg.mozilla.org/mozilla-central/rev/0f63c743885d

Comment 14

[Emily Wachowiak [:emilyw]]

The new string ‘Always open links in apps’ looks good to me!