Closed Bug 1920080 Opened 1 year ago Closed 1 year ago

Remove global constructors from modules/libpref/Preferences.cpp

Categories

(Firefox Build System :: General, task)

task

Tracking

(firefox134 fixed)

RESOLVED FIXED
134 Branch
Tracking Status
firefox134 --- fixed

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(1 file, 1 obsolete file)

No description provided.

Move test code to modules/libpref/test/gtest/Parser.cpp and remove a
global constructor in the process.

Attachment #9426153 - Attachment description: Bug 1920080 - Remove global constructors and test code from modules/libpref/Preferences.cpp r=chutten → Bug 1920080 - Remove global constructors and test code from modules/libpref/Preferences.cpp r=glandium

This make it possible to flag a few MOZ_RUNINIT variables as
MOZ_CONSTINIT.

Attachment #9426153 - Attachment is obsolete: true
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/75935042f60b Make nsCString default constructor constexpr r=glandium,xpcom-reviewers,emilio

Backed out for for causing assertion failure on FetchUtil.cpp

Backout link

Push with failures

Failure log

Flags: needinfo?(sguelton)
Attachment #9434422 - Attachment description: Bug 1920080 - Make nsCString default constructor constexpr r=glandium → Bug 1920080 - Make nsCString default constructor constexpr r=glandium!
Pushed by sguelton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ff02f7523cd Make nsCString default constructor constexpr r=glandium,xpcom-reviewers,emilio
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 134 Branch
Flags: needinfo?(sguelton)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: